Fix geo link could not be copied to clipboard #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is kind of the inverse of https://github.com/nextcloud/maps/pull/986/files, which fixed #986 As I remember at that time $this.copyText() was not working reliable and I shifted to navigator.clipboard.writeText(text) |
Signed-off-by: Alaskan Puffin <alaskanpuffin@protonmail.com>
alaskanpuffin
force-pushed
the
copy-geolocation-fix
branch
from
f8b844b
to
68fad6b
Compare
|
Fixed, that's a much cleaner solution. Thanks |
tacruc
approved these changes
Jul 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1028. Was missing the vue-clipboard2 package which provides the this.$copyText() method used in Map.vue line 876.