Fix loading of tracks #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flow seems to be: ``` occ maps:scan-tracks ``` adds the tracks to the db with `$metadata = ""`. Then, when the UI initially requests a specific track the metadata is generated. This however never happens since the UI code attempts to parse the metadata as JSON before. Fixed by checking for an empty string before (in which case we return an empty object (the metadata will be read again later when displaying an individual track)). I am not sure why the metadata is read here it all. Maybe the parsing call be be removed completly if it happens again later anyway? Fixes: nextcloud#574 Signed-off-by: Erik Schilling <git@ablu.org>
Ablu
force-pushed
the
fix-tracks-loading
branch
from
569a6dd
to
bbc7374
Compare
Julianoe
approved these changes
Jun 3, 2021
|
I stubled upon the same Problem. However, unaware of this pullrequest, I did my own fix using try/catch in order to catch malformed json in general: replaced line 294: this.tracks[track.id].metadata = $.parseJSON(track.metadata); I am not sure if it is neccessary at all and if there will be cases of malformed json besides an empty string but I just hope for a fixed version soon. This pullrequest works for me too, |
julien-nc
approved these changes
Jul 5, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flow seems to be:
adds the tracks to the db with
$metadata = "". Then, when the UIinitially requests a specific track the metadata is generated. This
however never happens since the UI code attempts to parse the metadata
as JSON before. Fixed by checking for an empty string before (in which
case we return an empty object (the metadata will be read again later
when displaying an individual track)).
I am not sure why the metadata is read here it all. Maybe the parsing
call be be removed completly if it happens again later anyway?
Fixes: #574