Reactor/files app #556
Merged
Reactor/files app #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikolas Rimikis <rimikis.nikolas@gmail.com>
|
Why is it in draft if I should already review? 👀 |
Because I love the UX of github 🙄 |
|
Ah yeah it remembers what type of PR you last submitted. I also hate it so much lol |
provokateurin
requested changes
Aug 13, 2023
Signed-off-by: Nikolas Rimikis <rimikis.nikolas@gmail.com>
Signed-off-by: Nikolas Rimikis <rimikis.nikolas@gmail.com>
Signed-off-by: Nikolas Rimikis <rimikis.nikolas@gmail.com>
Leptopoda
force-pushed
the
reactor/files_app
branch
from
9dc4e42
to
94577d2
Compare
This was referenced Aug 15, 2023
provokateurin
requested changes
Aug 15, 2023
Leptopoda
force-pushed
the
reactor/files_app
branch
from
94577d2
to
95084d1
Compare
provokateurin
requested changes
Aug 15, 2023
… sealed Task class Signed-off-by: Nikolas Rimikis <rimikis.nikolas@gmail.com>
Leptopoda
force-pushed
the
reactor/files_app
branch
from
95084d1
to
a7b0dda
Compare
provokateurin
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improves the files app performance as mentioned in #445.
#282 will still gain us a bit more.
@provokateurin please review thoroughly :)