Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/automatic spell checking #840

Merged
merged 2 commits into from Sep 25, 2023
Merged

Feature/automatic spell checking #840

merged 2 commits into from Sep 25, 2023

Conversation

provokateurin
Copy link
Member

Closes #834

@provokateurin
Copy link
Member Author

Works as expected: https://github.com/nextcloud/neon/actions/runs/6284283715/job/17065500854

Leptopoda
Leptopoda reviewed Sep 23, 2023
View reviewed changes
Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should reorganize the dictionaries into:

  • dart/flutter (only containing dart stuff)
  • dependencies/libraries (containing stuff we can't controll like rxdart or zxing
  • misc
  • custom

For some less common things you should also add some comments like what even is seti or siacs

README.md Outdated Show resolved Hide resolved
.cspell/dart.txt Outdated Show resolved Hide resolved
.cspell/misc.txt Outdated Show resolved Hide resolved
.cspell/neon.txt Outdated Show resolved Hide resolved
.cspell/neon.txt Outdated Show resolved Hide resolved
.cspell/neon.txt Outdated Show resolved Hide resolved
cspell.json Show resolved Hide resolved
.cspell/dart.txt Outdated Show resolved Hide resolved
@provokateurin
Copy link
Member Author

I added a script to update the dictionaries (to remove outdated words).
I wasn't sure how to best organize the dictionaries, but we can try your idea.

@provokateurin
Copy link
Member Author

I'm not sure why the CI has a problem with openapi while I locally don't have the problem (running the latest version).

Leptopoda
Leptopoda reviewed Sep 23, 2023
View reviewed changes
Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But now we have some duplications like foss and FOSS and it was passing fine without them.

@provokateurin
Copy link
Member Author

This depends on nextcloud/notifications#1673

@provokateurin provokateurin marked this pull request as draft September 24, 2023 08:09
@Leptopoda Leptopoda mentioned this pull request Sep 24, 2023
Closed
@provokateurin
feat(tool): Setup cspell
a4e21f5 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
@provokateurin
chore: Fix typos
a2132ed 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
@provokateurin provokateurin marked this pull request as ready for review September 25, 2023 12:30
@provokateurin provokateurin merged commit b49f49d into main Sep 25, 2023
4 checks passed
@provokateurin provokateurin deleted the feature/automatic-spell-checking branch September 25, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leptopoda Leptopoda Leptopoda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup automatic spell checking
2 participants
@provokateurin @Leptopoda