-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Articles marked as read via web app -> sidebar -> Unread articles -> Mark read show as unread in Android app #1105
Comments
Happens to me as well, also with latest News/Android app on NC24. |
Thank you for the report. really weird.. classic example of .. works on my machine 😅 I'm running Nextcloud 24.0.3, and News v18.1.0 as well.. can't reproduce the issue. If I mark a whole feed as read in the web ui the changes are reflected in the app. If I mark a single item as read it also gets synced to the app properly.. 🤔 |
Thanks for replying! Those things work for me too - marking a single item, a whole feed, or a folder in web UI as read is properly synced and Android app sees them as read immediately. What doesn't work for me is if I go this route: open web UI -> click on |
@markochk Oh okay, thanks for the clarification. So basically you are marking all unread items in your news app (web) as read in a single transaction. The only thing I can think of that could go wrong is that the response from the server is too large for the app to handle (e.g. too many items were changed). However that wouldn't explain why consecutive syncs work properly. How many articles are usually unread when you press that button? |
Not sure, I don't think it is directly related. But when I have time I will check again, maybe there is some difference in when the api marks something as read compared to the UI. |
Max 70-80, but it happens even if it's as few as 10 articles. Something odd just happened: I haven't used the Android app in a while (because of this issue), so after your replies I openened it to check, expecting to see the unread article count in the thousands, but it showed the same value as in the web app (only 58). Now, checking all unread articles as read in the web app still didn't make them show as read in the Android app, but I think it's weird the unread article count was the same as in web app. Nextcloud Android app: v0.9.9.76 |
What DB server software do you use? |
Nextcloud > Settings > System > Database prints:
I hope this is what you were asking for; sorry if it's not. If it's of any use, syncing things like files, CardDAV, CalDAV etc. is pretty much instantaneous. |
I can confirm this issue. NextCloud 26.0.0 |
Thanks for the testing, I think the issue is in https://github.com/nextcloud/news/blob/master/lib/Db/ItemMapperV2.php I will check when I have time, if it is what I think it should be easy to fix |
Can this be the same root cause, #1117 ? |
Yes very likely, I think I found the problem, the code that handles this specific update is different to the Feed update or single item update (didn't check folder) and there the update of the timestamp was missing. Since the sync is based on timestamps the following will happen. You mark feeds on the server as read - timestamp not updated Should be easy to fix already made a change only need to adjust tests, lint,... :) |
Wow! Thanks. |
This issues is similar to (or a possible duplicate of) #975.
From a web app, marking a single article, a feed or a folder as read works properly, with Android app seeing them as read, but when going web app -> sidebar -> Unread articles (or All articles) -> Mark read, these articles still show as unread in the Android app. Over time I've accumulated around 3400 unread articles in the Android app while there are no unread articles in the web app.
Nextcloud Android app: v0.9.9.75
Nextcloud News web app: v18.1.0
Nextcloud: v24.0.3
The text was updated successfully, but these errors were encountered: