New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh a feed or folder through "pull to refresh" gesture #320
Comments
"Download more items" is only for downloading older already read items. Probably we can change this in a future release to something like WhatsApp is doing when you're scrolling up the "Load more messages" button appears. But is this really a feature which is useful? I think you can make a swipe left and refresh all your feeds. It should only take a few seconds to update (Depending on your internet connection). I think it would be confusing when you're able to "pull-to-refresh" a single feed/folder and in the sliding pane you can update all of your feeds. And we already have the "Refresh" Button in the Actionbar when you're in a Feed/Folder. So it also might be a problem for the sync because when you "refresh" a single folder and you open the slider, the Loading indicator should be visible because you can't trigger two sync's at once but then the sync indicator is not indicating that all news are getting updated (I hope you know what I mean?). |
Okay, I see the problem. I recently switched over from Taptu (they were discontinuing their service) and missed this feature a bit. There it was possible to update all feeds at once or just one feed individually. Of course this doesn't make any sense when you can't trigger two syncs at once. Maybe it makes sense to trigger the same action as the "Refresh" button in the Actionbar when pulling down the list. It's a familiar gesture and at least you can continue reading the newest items of the current feed/folder after refreshing it. |
I see that it's more natural and common to use the "pull to refresh" feature instead of the button in the actionbar. But anyway we still have the same issue. There are two loading indicators (with the same layout). So when you trigger an update in a feed/folder and then open the sliding pane, the loading indicator appears there, too! (On Tablets in Landscape mode you have both loading indicator visible at once). So I think this is critical from the UX point of view. What do the others think? |
Pulling down should load newer items. In the same way, scrolling to the bottom of the list and further should load more older items. Any extra context menu entries for "load more" or "refresh" should be removed. And the only loading indicators should be in the list, not in the top bar. Hope that helps. :) |
Ich bin ganz deiner Meinung, der "Load more" Menü Eintrag für ältere Einträge wird auch demnächst entfernt. Das Problem ist jedoch folgendes: Wenn wir wirklich ein das pull-to-refresh in der Feed/Folder Ansicht aktivieren, dann sind zwei Pull-To-Refresh Views direkt nebeneinander. Mit derselben bedeutung. Von daher bin ich mir nicht sicher ob das Designtechnisch so optimal ist. Die Frage ist, ob es auch in diesem View implementiert werden soll: Die Views liegen ja direkt (mit einem Swipe erreichbar) nebeneinander von daher würde das vielleicht mehr Verwirrung stiften als helfen? Btw. auf Tablets sind beide Views immer sichtbar Siehe hier: |
I agree. From a new users perspective this would be the expected behavior.
I thought about that, but it would be bad for people with disabilities. The documentation states: "The SwipeRefreshLayout does not provide accessibility events; instead, a menu item must be provided to allow refresh of the content wherever this gesture is used." (https://developer.android.com/reference/android/support/v4/widget/SwipeRefreshLayout.html).
Yes, one should be enough. That could be tricky to program when switching views, but I'm not sure about that.
I don't see why the gesture should work on one view and not the other. I think ideally (and I'm not thinking about the technical implications right now) it should be possible to refresh all feeds/folders through a pull to refresh gesture on the sliding pane. One loading indicator should be enough and it makes sense to use the holo one inside the view and don't change the action bar. It should also be possible to load newer articles of one feed/folder through a pull to refresh gesture of the feed/folder list. Here one loading indicator above the list would be fine too. Loading older items should be possible after scrolling the list completely down - either through a pull to refresh gesture on the bottom of the list or a "load more" button as last list item (then the menu item could be removed). The only problem with this whole setting (apart from some implementation work to refresh only one feed/folder) is that there can be only one refresh at a time. Two different pull to refresh gestures have the implication that they could occur simultaneously which is - as I understand - not possible right now. Is there anything I missed? |
Yeah, I’d say pull to refresh should be available in both views. For now it could mean to reload everything even when only in a feed – cause it achieves what you want in reloading the feed as well. In the future it would be good if a pull to refresh inside a feed would only refresh that feed. If possible. |
Since this issue hasn't gotten any reasonable interest in almost a decade I'm closing it. Also: Other apps such as the Nextcloud Deck app only have "Pull to refresh" in the main view and not the sidebar. |
It would be nice to be able to refresh a single feed or folder by swiping the top of the feed list further down. I started implementing this feature frontend wise (cemrich/News-Android-App@db63ec1) but the "Download more items" feature that is currently implemented is not quite what I expected. It will download older news items - even when marked as read - but no newer ones. Of course the "pull down" gesture makes no sense for downloading old items.
Is there a possibility to download all new items of the current feed or folder? Something like
AsyncTask_GetItems
seems like a good start when it would be restricted to one feed or folder.The text was updated successfully, but these errors were encountered: