DB: Updates should use set()

Issue GH-1211

Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>

CHANGELOG.md

@@ -7,6 +7,7 @@ The format is almost based on [Keep a Changelog](https://keepachangelog.com/en/1
 ### Changed
 
 ### Fixed
+- Fix update queries (#1211)
 
 ## [15.4.0-beta2] - 2021-02-27
 ### Fixed

lib/Db/FeedMapperV2.php

@@ -164,7 +164,7 @@ public function read(string $userId, int $id, ?int $maxItemID = null): void
         $builder = $this->db->getQueryBuilder();
         $builder->update(ItemMapperV2::TABLE_NAME, 'items')
             ->innerJoin('items', FeedMapperV2::TABLE_NAME, 'feeds', 'items.feed_id = feeds.id')
-            ->setValue('unread', 0)
+            ->set('unread', 0)
             ->andWhere('feeds.user_id = :userId')
             ->andWhere('feeds.id = :feedId')
             ->setParameter('userId', $userId)

lib/Db/FolderMapperV2.php

@@ -108,7 +108,7 @@ public function read(string $userId, int $id, ?int $maxItemID = null): void
         $builder = $this->db->getQueryBuilder();
         $builder->update(ItemMapperV2::TABLE_NAME, 'items')
             ->innerJoin('items', FeedMapperV2::TABLE_NAME, 'feeds', 'items.feed_id = feeds.id')
-            ->setValue('unread', 0)
+            ->set('unread', 0)
             ->andWhere('feeds.user_id = :userId')
             ->andWhere('feeds.folder_id = :folderId')
             ->setParameter('userId', $userId)

lib/Db/ItemMapperV2.php

@@ -261,7 +261,7 @@ public function readAll(string $userId, int $maxItemId): void
 
         $builder->update($this->tableName, 'items')
                 ->innerJoin('items', FeedMapperV2::TABLE_NAME, 'feeds', 'items.feed_id = feeds.id')
-                ->setValue('unread', 0)
+                ->set('unread', 0)
                 ->andWhere('items.id =< :maxItemId')
                 ->andWhere('feeds.user_id = :userId')
                 ->setParameter('maxItemId', $maxItemId)

tests/Unit/Db/FeedMapperTest.php

@@ -472,7 +472,7 @@ public function testRead()
             ->will($this->returnSelf());
 
         $this->builder->expects($this->once())
-            ->method('setValue')
+            ->method('set')
             ->with('unread', 0)
             ->will($this->returnSelf());
 
@@ -517,7 +517,7 @@ public function testReadWithMaxId()
             ->will($this->returnSelf());
 
         $this->builder->expects($this->once())
-            ->method('setValue')
+            ->method('set')
             ->with('unread', 0)
             ->will($this->returnSelf());
 
@@ -541,4 +541,4 @@ public function testReadWithMaxId()
 
         $this->class->read('admin', 1, 4);
     }
-}
+}

tests/Unit/Db/FolderMapperTest.php

@@ -300,7 +300,7 @@ public function testRead()
             ->will($this->returnSelf());
 
         $this->builder->expects($this->once())
-            ->method('setValue')
+            ->method('set')
             ->with('unread', 0)
             ->will($this->returnSelf());
 
@@ -345,7 +345,7 @@ public function testReadWithMaxId()
             ->will($this->returnSelf());
 
         $this->builder->expects($this->once())
-            ->method('setValue')
+            ->method('set')
             ->with('unread', 0)
             ->will($this->returnSelf());
 
@@ -369,4 +369,4 @@ public function testReadWithMaxId()
 
         $this->class->read('admin', 1, 4);
     }
-}
+}

tests/Unit/Db/ItemMapperTest.php

@@ -487,7 +487,7 @@ public function testReadAll()
             ->will($this->returnSelf());
 
         $this->builder->expects($this->once())
-            ->method('setValue')
+            ->method('set')
             ->with('unread', 0)
             ->will($this->returnSelf());
 
@@ -1055,4 +1055,4 @@ public function testDeleteOverThresholdSuccessUnreadSkipsIfUnderThreshold()
         $this->assertSame(10, $res);
     }
 
-}
+}