Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If an article doesn't have title, there's no link to the article #758

Open
1 task done
RomanYankovsky opened this issue Aug 15, 2020 · 13 comments
Open
1 task done
Labels
2. developing enhancement frontend impact Javascript/Frontend code
Milestone

Comments

@RomanYankovsky
Copy link

RomanYankovsky commented Aug 15, 2020

Read and tick the following checkbox after you have created the issue or place an x inside the brackets ;)

Is your feature request related to a problem? Please describe.
If an article doesn't have title, there's no link to the article. Technically it's there, but as the text inside <a></a> tag is empty, it's not visible and not clickable.

Describe the solution you'd like
Update timestamp on the right side to make it a link to original article, or/and use a placeholder like "(no title)" when title is empty in order to make it visible and clickable.

Additional context
изображение


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@JonathanTreffler
Copy link

I am currently working on a frontend rewrite in vue and will fix this issue there. I dont think it is worth fixing this in the current Code

@RomanYankovsky
Copy link
Author

@JonathanTreffler Do you have the issue ID for the reference?

@JonathanTreffler
Copy link

Yes, #748 and #195

@JonathanTreffler JonathanTreffler added this to the Vue Rewrite milestone Aug 17, 2020
@stale
Copy link

stale bot commented Sep 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Sep 7, 2020
@stale stale bot closed this as completed Sep 14, 2020
@Grotax Grotax reopened this Sep 14, 2020
@stale stale bot removed the stale label Sep 14, 2020
@SMillerDev SMillerDev added the frontend impact Javascript/Frontend code label Dec 11, 2020
@romanblanco
Copy link

romanblanco commented Feb 27, 2021

Maybe relevant issue to pay attention to during rewrite:

In some cases it happens that the href of [link] does not contain full path ([comments] link works correctly):

<div class="body" news-bind-html-unsafe="item.body" ng-attr-dir="{{item.rtl &amp;&amp; 'rtl'}}" dir="false">  submitted by   
  <a target="_blank" rel="noreferrer" href="https://www.reddit.com/user/MichaelCade"> /u/MichaelCade 
  </a>   to   
  <a target="_blank" rel="noreferrer" href="https://www.reddit.com/r/kubernetes/"> r/kubernetes </a>
  <br>
  <span><a target="_blank" rel="noreferrer" href="/r/Kasten/comments/lsw4bq/building_the_home_lab_kubernetes_playground_part_2/">[link]</a></span>
  <span><a target="_blank" rel="noreferrer" href="https://www.reddit.com/r/kubernetes/comments/lsw54e/building_the_home_lab_kubernetes_playground_part_2/">[comments]</a></span>
</div>
  • Nextcloud 20.0.4
  • PHP Version: 7.4.13
  • Database
    Type: mysql
    Version: 10.5.8

@IgorA100
Copy link
Contributor

IgorA100 commented Feb 14, 2023

In some cases it happens that the href of [link] does not contain full path ([comments] link works correctly):

I suggested a solution here: #1952 & #2100

@uncovery
Copy link

Duplicate of #2037?

@LinAGKar
Copy link

This has become an issue for Mastodon feeds, since they've removed their titles: mastodon/mastodon#18640

@Grotax
Copy link
Member

Grotax commented Jun 20, 2023

Yea that's very unfortunate, there has been no movement on the front-end part unfortunately.

And as the frontend works even less with the recently released Nextcloud 27.
We are considering removing the frontend completely..

@SMillerDev
Copy link
Contributor

Is this fixed in the new frontend @Grotax ?

@Grotax
Copy link
Member

Grotax commented Oct 29, 2023

No idea, haven't seen such a feed yet. Without an example it's hard to tell what would happen.

@Grotax
Copy link
Member

Grotax commented Oct 29, 2023

I will check when I have time.

@Grotax
Copy link
Member

Grotax commented Oct 29, 2023

Not fully fixed, the Feeds from Mastodon for example do not provide a title at all.
So the field in the DB is null. In the new frontend, there is simply nothing then. But it can handle it.
There is still the icon to open the website and nothing breaks.

I guess some improvement could still be made here, to display something there and link it to the url of the item.

In the DB the field should still be null since it reflects the feed as is.

For other case idk, we need example feeds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing enhancement frontend impact Javascript/Frontend code
Projects
None yet
Development

No branches or pull requests

8 participants