Support for relative links in the Title and in Body. Update FeedFetcher.php #2100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for relative links in the Title and in Body. Signed-off-by: IgorA100 <igora100@gmail.com>
IgorA100
changed the title
|
This should really be fixed in feed.io, allowing us to request a full URL. |
1 task
Signed-off-by: IgorA100 <igora100@gmail.com>
IgorA100
added a commit
to IgorA100/news
that referenced
this pull request
Feb 14, 2023
- Support for relative links in the Title and in Body. (nextcloud#2100 Signed-off-by: IgorA100 <igora100@gmail.com>
Am I making corrections in the wrong place? |
|
Well, kind of, the feed parser used by NC News is debril/feed-io (currently using v4.x, but v5 is planned for the near future) and this kind of fix is best implemented there. |
|
I created a PR alexdebril/feed-io#419, but I am alarmed that there have been no new commits for almost a year... My PR in main is approved. |
|
I close it as completed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for relative links in the Title and in Body.
Signed-off-by: IgorA100 igora100@gmail.com
Summary
Checklist