Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB: Don't show deleted feed items #1258

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

SMillerDev
Copy link
Contributor

Should resolve an issue reported by @anoymouserver in chat

@codecov-io
Copy link

Codecov Report

Merging #1258 (69efb75) into master (4e1d6ea) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1258      +/-   ##
============================================
+ Coverage     87.19%   87.31%   +0.11%     
  Complexity      701      701              
============================================
  Files            60       60              
  Lines          2514     2514              
============================================
+ Hits           2192     2195       +3     
+ Misses          322      319       -3     
Impacted Files Coverage Δ Complexity Δ
lib/Db/ItemMapperV2.php 100.00% <100.00%> (ø) 53.00 <0.00> (ø)
lib/Fetcher/FeedFetcher.php 88.57% <0.00%> (-0.17%) 37.00% <0.00%> (ø%)
lib/Service/FeedServiceV2.php 100.00% <0.00%> (ø) 28.00% <0.00%> (ø%)
lib/Command/Debug/ItemList.php 0.00% <0.00%> (ø) 6.00% <0.00%> (ø%)
lib/Command/Debug/FeedItemList.php 0.00% <0.00%> (ø) 6.00% <0.00%> (ø%)
lib/Command/Debug/FolderItemList.php 0.00% <0.00%> (ø) 8.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e1d6ea...69efb75. Read the comment docs.

Copy link
Contributor

@anoymouserver anoymouserver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 👍

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
@SMillerDev SMillerDev merged commit baf1ca8 into nextcloud:master Mar 23, 2021
@SMillerDev SMillerDev deleted the fix/items/deleted_in_list branch March 23, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants