Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for Nextcloud 20 #1514

Merged
merged 4 commits into from Nov 18, 2021
Merged

Remove support for Nextcloud 20 #1514

merged 4 commits into from Nov 18, 2021

Conversation

Grotax
Copy link
Member

@Grotax Grotax commented Sep 26, 2021

To be merged when nc 20 support ends.

@codecov-commenter
Copy link

Codecov Report

Merging #1514 (20f3535) into master (4ee8166) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 20f3535 differs from pull request most recent head bd3a235. Consider uploading reports for the commit bd3a235 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1514      +/-   ##
============================================
+ Coverage     92.00%   92.02%   +0.01%     
  Complexity      766      766              
============================================
  Files            65       65              
  Lines          2803     2796       -7     
============================================
- Hits           2579     2573       -6     
+ Misses          224      223       -1
Impacted Files Coverage Δ
lib/Service/FeedServiceV2.php 100.00% <0.00%> (ø)
lib/Command/Debug/ItemList.php 100.00% <0.00%> (ø)
lib/Command/Debug/FeedItemList.php 100.00% <0.00%> (ø)
lib/Command/Debug/FolderItemList.php 100.00% <0.00%> (ø)
lib/Fetcher/FeedFetcher.php 89.11% <0.00%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ee8166...bd3a235. Read the comment docs.

@SMillerDev
Copy link
Contributor

There's a couple of TODO comments for this as well, can you do that? Or should I?

anoymouserver
anoymouserver reviewed Sep 28, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@Grotax
Copy link
Member Author

Grotax commented Sep 29, 2021

There's a couple of TODO comments for this as well, can you do that? Or should I?

Oh I didn't even know that. So probably you should do that. Feel free to use this branch.

@Grotax Grotax force-pushed the drop/nextcloud20 branch 3 times, most recently from 6243069 to 858fe21 Compare October 7, 2021 16:45
@Grotax
Copy link
Member Author

Grotax commented Nov 15, 2021 •
edited

Nextcloud 20 is now EOL https://github.com/nextcloud/server/wiki/Maintenance-and-Release-Schedule

Meanwhile NC 23 has a RC2, probably no changes needed for news, interesting fact php 7.3 becomes deprecated so we can probably remove that soon. nextcloud/server#27846

I want to release another 16.2.x update to fix #1570, then I would say 17.0.0 should be prepared for NC23 together with this PR being merged.

If I have time I will also check on the TODOs

@Grotax Grotax changed the title Drop/nextcloud20 Remove support for Nextcloud 20 Nov 15, 2021
@Grotax
Copy link
Member Author

Grotax commented Nov 15, 2021

I checked the todos but I'm not sure what the plan was they just say to update the db functions with NC21, maybe because if NC21 is the minimum better queries are possible?

@SMillerDev
Copy link
Contributor

Yeah, we can move from the deprecated to the new query execution methods.

@Grotax
Copy link
Member Author

Grotax commented Nov 15, 2021

Ah I see, yea I have no idea about that.

@Grotax Grotax force-pushed the drop/nextcloud20 branch 2 times, most recently from 0e3e5c8 to 5875310 Compare November 15, 2021 20:07
@Grotax
Copy link
Member Author

Grotax commented Nov 15, 2021

Looks good to me :) 👍

@Grotax
Copy link
Member Author

Grotax commented Nov 15, 2021

Ah we should maybe remove the TODOs right?

Grotax and others added 4 commits November 18, 2021 14:03
@Grotax
Drop support for Nextcloud 20
628d32a 
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@SMillerDev @Grotax
chore: use executeStatement instead of executeUpdate
72df4d7 
Signed-off-by: Sean Molenaar sean@seanmolenaar.eu
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@Grotax
Update changelog for 17.x.x
358911e 
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@Grotax
Fix code style
f1f0ff3 
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@Grotax
Copy link
Member Author

Grotax commented Nov 18, 2021

I removed the todo markers

@Grotax Grotax merged commit f0a1c92 into master Nov 18, 2021
@delete-merged-branch delete-merged-branch bot deleted the drop/nextcloud20 branch November 18, 2021 13:10
Grotax added a commit that referenced this pull request Nov 18, 2021
@Grotax
Release 17.0.0-beta1
7da8214 
Changed
- Drop support for Nextcloud 20 (#1514)
- Use better sql commands, that were not possible with Nextcloud 20 (#1514)
- Add support for Nextcloud 23

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@Grotax Grotax mentioned this pull request Nov 18, 2021
Merged
Grotax added a commit that referenced this pull request Nov 18, 2021
@Grotax
Release 17.0.0-beta1
7774b92 
Changed
- Drop support for Nextcloud 20 (#1514)
- Use better sql commands, that were not possible with Nextcloud 20 (#1514)
- Add support for Nextcloud 23 (#1585)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Grotax added a commit that referenced this pull request Nov 18, 2021
@Grotax
Release 17.0.0-beta1
9613ee0 
Changed
- Drop support for Nextcloud 20 (#1514)
- Use better sql commands, that were not possible with Nextcloud 20 (#1514)
- Add support for Nextcloud 23 (#1585)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Neo11 pushed a commit to Neo11/news that referenced this pull request May 28, 2022
@Grotax
Release 17.0.0-beta1
e9dbed8 
Changed
- Drop support for Nextcloud 20 (nextcloud#1514)
- Use better sql commands, that were not possible with Nextcloud 20 (nextcloud#1514)
- Add support for Nextcloud 23 (nextcloud#1585)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SMillerDev SMillerDev SMillerDev approved these changes

@anoymouserver anoymouserver Awaiting requested review from anoymouserver

Assignees
No one assigned
Labels
2. developing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Grotax @codecov-commenter @SMillerDev @anoymouserver