Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shortcuts #1669

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Update shortcuts #1669

merged 1 commit into from
Feb 21, 2022

Conversation

dennmuel
Copy link
Contributor

Shortcut "q" is not supported anymore as stated in #1613 (comment)
Shortcuts "c" and "v" seemed to have swapped descriptions.

@codecov-commenter
Copy link

Codecov Report

Merging #1669 (debac66) into master (9f53939) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1669      +/-   ##
============================================
- Coverage     91.45%   91.42%   -0.03%     
  Complexity      767      767              
============================================
  Files            65       65              
  Lines          2831     2835       +4     
============================================
+ Hits           2589     2592       +3     
- Misses          242      243       +1     
Impacted Files Coverage Δ
lib/Fetcher/FeedFetcher.php 78.44% <0.00%> (-0.26%) ⬇️
lib/Service/FeedServiceV2.php 100.00% <0.00%> (ø)
lib/Command/Debug/ItemList.php 100.00% <0.00%> (ø)
lib/Command/ExploreGenerator.php 100.00% <0.00%> (ø)
lib/Explore/RecommendedSites.php 0.00% <0.00%> (ø)
lib/Controller/FeedController.php 100.00% <0.00%> (ø)
lib/Controller/PageController.php 100.00% <0.00%> (ø)
lib/Command/Debug/FeedItemList.php 100.00% <0.00%> (ø)
lib/Fetcher/Client/FeedIoClient.php 100.00% <0.00%> (ø)
lib/Command/Debug/FolderItemList.php 100.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f53939...debac66. Read the comment docs.

@SMillerDev
Copy link
Contributor

Could you add an entry for this in Changelog.md? That way we can give proper credit to the changes you made.

Shortcut "q" is not supported anymore as stated in #1613 (comment)
Shortcuts "c" and "v" seemed to have swapped descriptions.

Signed-off-by: Dennis Müller <dennis.mueller@bib.uni-mannheim.de>
@dennmuel
Copy link
Contributor Author

Sure! Sorry, I just missed that somehow.
Btw: I just came back to NC News after trying a few other feedreaders and it kinda felt like 'coming home'. :) Thank you!

Copy link
Contributor

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dennmuel !

@SMillerDev SMillerDev merged commit dbf6db8 into nextcloud:master Feb 21, 2022
@dennmuel dennmuel deleted the patch-1 branch February 22, 2022 07:21
Grotax added a commit that referenced this pull request Feb 23, 2022
Changed
- Change shortcut descriptions. (#1669)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@Grotax Grotax mentioned this pull request Feb 23, 2022
Grotax added a commit that referenced this pull request Feb 27, 2022
Changed
- Change shortcut descriptions. (#1669)

Fixed
- Fix spaces in passwords getting replaced with "+" (#1678)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Grotax added a commit that referenced this pull request Feb 28, 2022
Changed
- Change shortcut descriptions. (#1669)

Fixed
- Fix spaces in passwords getting replaced with "+" (#1678)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Neo11 pushed a commit to Neo11/news that referenced this pull request May 28, 2022
Changed
- Change shortcut descriptions. (nextcloud#1669)

Fixed
- Fix spaces in passwords getting replaced with "+" (nextcloud#1678)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants