Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mark items of folder as read #1703

Merged
merged 1 commit into from
Mar 18, 2022
Merged

fix mark items of folder as read #1703

merged 1 commit into from
Mar 18, 2022

Conversation

Grotax
Copy link
Member

@Grotax Grotax commented Mar 18, 2022

documented: https://nextcloud.github.io/news/api/api-v1/#mark-items-of-a-folder-as-read

Was not implemented according to docs.
Tested with #1699

@Grotax Grotax force-pushed the fix/api branch 2 times, most recently from 5adb39c to c94dde2 Compare March 18, 2022 10:26
Copy link
Contributor

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Grotax !

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@codecov-commenter
Copy link

Codecov Report

Merging #1703 (ebe31d5) into master (4096408) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #1703   +/-   ##
=========================================
  Coverage     91.86%   91.86%           
  Complexity      766      766           
=========================================
  Files            65       65           
  Lines          2692     2705   +13     
=========================================
+ Hits           2473     2485   +12     
- Misses          219      220    +1     
Impacted Files Coverage Δ
lib/Controller/FolderApiController.php 100.00% <100.00%> (ø)
lib/Db/FolderMapperV2.php 96.15% <100.00%> (ø)
lib/Service/FolderServiceV2.php 100.00% <100.00%> (ø)
lib/Command/ExploreGenerator.php 100.00% <0.00%> (ø)
lib/Explore/RecommendedSites.php 0.00% <0.00%> (ø)
lib/Controller/FeedController.php 100.00% <0.00%> (ø)
lib/Controller/PageController.php 100.00% <0.00%> (ø)
lib/Fetcher/Client/FeedIoClient.php 100.00% <0.00%> (ø)
lib/Controller/FeedApiController.php 100.00% <0.00%> (ø)
lib/Db/Feed.php 99.05% <0.00%> (+<0.01%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4096408...ebe31d5. Read the comment docs.

@Grotax Grotax merged commit c49e0fb into master Mar 18, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/api branch March 18, 2022 10:54
Grotax added a commit that referenced this pull request Mar 22, 2022
Fixed
- Fix no item marked as read by Folder API due to mismatch in parameter name (#1703)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@Grotax Grotax mentioned this pull request Mar 22, 2022
Grotax added a commit that referenced this pull request Mar 22, 2022
Fixed
- Fix no item marked as read by Folder API due to mismatch in parameter name (#1703)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Neo11 pushed a commit to Neo11/news that referenced this pull request May 28, 2022
Fixed
- Fix no item marked as read by Folder API due to mismatch in parameter name (nextcloud#1703)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants