Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FAQ url #1705

Merged
merged 2 commits into from
Mar 19, 2022
Merged

Fix FAQ url #1705

merged 2 commits into from
Mar 19, 2022

Conversation

hooger
Copy link
Contributor

@hooger hooger commented Mar 18, 2022

Unfortuantely the contribution guide has a wrong URL for FAQ, I haven't found it myself. Found it in #1702 (comment)

How do I sign of my changes?

@hooger hooger mentioned this pull request Mar 18, 2022
3 tasks
@Grotax
Copy link
Member

Grotax commented Mar 18, 2022

If you can view the Details, the DCO bot tells you

CONTRIBUTING.md Outdated Show resolved Hide resolved
@codecov-commenter

This comment was marked as off-topic.

@hooger
Copy link
Contributor Author

hooger commented Mar 19, 2022

For the signoff should I use my real name or the login name for github?

@Grotax
Copy link
Member

Grotax commented Mar 19, 2022

I think that doesn't matter, but the mail needs to match otherwise the bot will complain

Signed-off-by: hooger <horvathg.1988@gmail.com>
Signed-off-by: hooger <horvathg.1988@gmail.com>
@hooger
Copy link
Contributor Author

hooger commented Mar 19, 2022

Thanks for the answer! Unfortunately the username has to match. :) How does it looks now?

@Grotax Grotax added the Skip-Changelog No changelog update is required, minor change label Mar 19, 2022
@Grotax
Copy link
Member

Grotax commented Mar 19, 2022

I think we don't need an entry in the changelog in this case as it doesn't affect the app at all.

@Grotax
Copy link
Member

Grotax commented Mar 19, 2022

git rebase -i HEAD~2
you will get a editor with the commit lines.
Replace the pick in front of the last commit for the changelog with a "d" for drop
Save and exit the editor

git push -f
to force the branch to be updated

@hooger
Copy link
Contributor Author

hooger commented Mar 19, 2022

There you go, I dropped the last commit as you asked.

@Grotax Grotax merged commit da980b7 into nextcloud:master Mar 19, 2022
@Grotax
Copy link
Member

Grotax commented Mar 19, 2022

Thanks 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog No changelog update is required, minor change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants