Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to speedup the api testing by hosting the feeds locally #1874

Merged
merged 4 commits into from
Aug 21, 2022

Conversation

Grotax
Copy link
Member

@Grotax Grotax commented Aug 19, 2022

No description provided.

@Grotax Grotax added the Skip-Changelog No changelog update is required, minor change label Aug 19, 2022
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@Grotax
Copy link
Member Author

Grotax commented Aug 19, 2022

Seems like it doesn't make a huge difference if the feed is hosted locally by the php server.

Also it would probably not work with the favicon tests, there we may still need to fetch the real feed.

But at least news sends less requests to the internet and we don't depend on the feeds being online.

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2022

Codecov Report

Merging #1874 (767879c) into master (fca05d5) will decrease coverage by 0.17%.
The diff coverage is 86.95%.

@@             Coverage Diff              @@
##             master    #1874      +/-   ##
============================================
- Coverage     91.62%   91.45%   -0.18%     
- Complexity      778      792      +14     
============================================
  Files            65       65              
  Lines          2724     2775      +51     
============================================
+ Hits           2496     2538      +42     
- Misses          228      237       +9     
Impacted Files Coverage Δ
lib/Cron/UpdaterJob.php 0.00% <0.00%> (ø)
lib/Db/ItemMapperV2.php 98.51% <60.00%> (-1.49%) ⬇️
lib/Service/FeedServiceV2.php 97.80% <81.81%> (-2.20%) ⬇️
lib/Fetcher/FeedFetcher.php 80.62% <95.00%> (+0.89%) ⬆️
lib/Db/Item.php 100.00% <100.00%> (ø)
lib/Db/NewsMapperV2.php 100.00% <100.00%> (ø)
lib/Utility/OPMLExporter.php 100.00% <100.00%> (ø)
lib/Command/ExploreGenerator.php 100.00% <0.00%> (ø)
lib/Explore/RecommendedSites.php 0.00% <0.00%> (ø)
lib/Controller/FeedController.php 100.00% <0.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@Grotax Grotax marked this pull request as ready for review August 21, 2022 14:37
@Grotax Grotax merged commit 49f7910 into master Aug 21, 2022
@delete-merged-branch delete-merged-branch bot deleted the test/speedup branch August 21, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog No changelog update is required, minor change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants