Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue Rewrite] Routes: Folder and All Articles Components and Routes #2346

Merged
merged 3 commits into from Sep 15, 2023

Conversation

devlinjunker
Copy link
Contributor

@devlinjunker devlinjunker commented Sep 4, 2023

Related to #748

Follows #2343

πŸ—’οΈ Summary

Add Route + Components for:

  • All Articles in Folder
  • All Articles in DB

Add More Material Design Icon Components to Side Panel

βœ… Checklist

- [ ] Changelog entry added for all important changes. (Can we add the skip-changelog label to prevent the check for changelog? )

πŸ“· Visual

All Articles Route:
Screenshot 2023-09-03 at 6 10 11 PM

Folder Articles Route:
Screenshot 2023-09-03 at 6 10 31 PM

Side Bar Icons:
Screenshot 2023-09-03 at 6 10 03 PM

➑️ Up Next

  • Sidebar Actions (WIP)
  • use ?selected=<id> url query parameter to store and parse which Feed Item is displayed in FeedItemDisplay
  • Update Documentation
  • Mobile friendly layout
  • Warning and Error Messages
  • Audio/Video Feed Items
  • Share Menu
  • Clean up Explore Panel
  • Quick access to Settings
    • Keyboard Navigation?
    • Reverse Order (Oldest to Newest)
    • Upload/Download Subscriptions/Articles
    • Mark on Scroll?
    • Compact/Expanded View?

Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
@simonspa simonspa added the Skip-Changelog No changelog update is required, minor change label Sep 14, 2023
@devlinjunker
Copy link
Contributor Author

devlinjunker commented Sep 14, 2023

Can we merge this?

Then I can create the next PR (for feed sidebar actions) with the correct rebase etc from https://github.com/devlinjunker/news/compare/folder+all-items-routes...devlinjunker:news:sidebar-actions?expand=1 (still working on unit tests though, so this will likely be a few more days)

@Grotax Grotax merged commit dce0701 into nextcloud:vue-rewrite Sep 15, 2023
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog No changelog update is required, minor change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants