Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Listener for missing db indices #2527

Merged
merged 6 commits into from Dec 30, 2023
Merged

Add Listener for missing db indices #2527

merged 6 commits into from Dec 30, 2023

Conversation

Grotax
Copy link
Member

@Grotax Grotax commented Dec 29, 2023

Summary

This should in theory allow admins to get the notification of missing indices and the option to add them via
occ db:add-missing-indices

tested:

  • changed migration creates the new index on first install
    grafik

  • occ db:add-missing-indices is offered in admin overview after upgrade
    grafik

root@5a630161f41e:/var/www/html# sudo -u www-data php ./occ db:add-missing-indices          
Adding additional news_feeds_deleted_at_index index to the oc_news_feeds table, this can take some time...
oc_news_feeds table updated successfully.

Checklist

@Grotax Grotax force-pushed the missingIndicies branch 2 times, most recently from 24a6355 to 2ac5f6a Compare December 30, 2023 09:38
@Grotax
Copy link
Member Author

Grotax commented Dec 30, 2023

got it working :) also fixed some other small things that I stumbled on during testing

this allows admins to add them via occ.

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@Grotax Grotax merged commit a8c2638 into master Dec 30, 2023
21 checks passed
@delete-merged-branch delete-merged-branch bot deleted the missingIndicies branch December 30, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

25.0.0-alpha3: missing index on feeds(deleted_at)
2 participants