Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vue improvements 2 #2569

Merged
merged 7 commits into from
May 7, 2024
Merged

Vue improvements 2 #2569

merged 7 commits into from
May 7, 2024

Conversation

powerpaul17
Copy link
Contributor

@powerpaul17 powerpaul17 commented Jan 25, 2024 •
edited
Loading

Summary

Checklist

@Grotax
Copy link
Member

Grotax commented Mar 13, 2024

Hey @powerpaul17 do you have time to continue this?

@powerpaul17
Copy link
Contributor Author

Yes, I want to finish this, maybe also fix a few other bugs. I'll try to do it in the next week. 😅

This was referenced Mar 29, 2024
Merged
Closed
@Moini
Copy link

Moini commented May 2, 2024

@powerpaul17 Is this ready? (except for the changelog entry)?

@powerpaul17
Copy link
Contributor Author

I guess it's best to mark this as finished and I create another PR when I have time for the other issues.

@powerpaul17 powerpaul17 marked this pull request as ready for review May 3, 2024 07:07
powerpaul17 and others added 7 commits May 7, 2024 13:46
@powerpaul17 @Grotax
move feed item list header actually into header
7084c23 
Signed-off-by: Paul Tirk <paultirk@paultirk.com>
@powerpaul17 @Grotax
grow main container of feed item row
a25138a 
Signed-off-by: Paul Tirk <paultirk@paultirk.com>
@powerpaul17 @Grotax
reset content scroll position when changing feed item
acd80fa 
Signed-off-by: Paul Tirk <paultirk@paultirk.com>
@powerpaul17 @Grotax
improve typing of feed item display list config
476728d 
Signed-off-by: Paul Tirk <paultirk@paultirk.com>
@powerpaul17 @Grotax
fix link to feed in article header
3fb66e7 
Signed-off-by: Paul Tirk <paultirk@paultirk.com>
@powerpaul17 @Grotax
add changelog entries
8bc76b2 
Signed-off-by: Paul Tirk <paultirk@paultirk.com>
@Grotax
update authors
dfa8de3 
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@Grotax Grotax enabled auto-merge (rebase) May 7, 2024 11:49
@Grotax Grotax merged commit 0fb5ed2 into nextcloud:master May 7, 2024
20 of 21 checks passed
Grotax added a commit that referenced this pull request May 7, 2024
@Grotax
Release 25.0.0-alpha6
c0c1ee2 
Changed
- Improve layout of feed item row (#2569)

Fixed
- Reset content scroll position when feed item is changed (#2569)
- Fix link to feed in article header (#2569)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@Grotax Grotax mentioned this pull request May 7, 2024
Merged
Grotax added a commit that referenced this pull request May 7, 2024
@Grotax
Release 25.0.0-alpha6
8b1666e 
Changed
- Improve layout of feed item row (#2569)

Fixed
- Reset content scroll position when feed item is changed (#2569)
- Fix link to feed in article header (#2569)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SMillerDev SMillerDev SMillerDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feed link at top of article view is broken
4 participants
@powerpaul17 @Grotax @Moini @SMillerDev