Add updatedDate to item model

[schaal]

Implement your suggestions from owncloud-archive/news#982 (comment)

• update picoFeed to 0.1.25
• add updated_date to the database
• use the new getPublishedDate and getUpdatedDate from picoFeed to set the corresponding item values
• adjust the unit tests

[BernhardPosselt]

Looks good, did you test it? You need to bump the version to 9.0.5 to start the migration

[schaal]

I did a quick test with the web interface and OCReader, should I update this pull request with a bumped version?

[BernhardPosselt]

yes

[BernhardPosselt]

BTW: https://github.com/nextcloud/news/blob/master/lib/Service/FeedService.php#L248

This probably needs to be adjusted

[BernhardPosselt]

👍

[BernhardPosselt]

Ok, things are broken because getPublishedDate() can return null: PHP Fatal error: Call to a member function getTimestamp() on null in /var/www/html/owncloud/apps/news/lib/Fetcher/FeedFetcher.php on line 243

Will revert PR

[schaal]

Why not just use getDate() if getPublishedDate() is null? If this is acceptable to you, I can send another pull request.

[BernhardPosselt]

@schaal shouldnt that be done in picoFeed instead?

[schaal]

Not sure, I could see it either way

[BernhardPosselt]

Right, you can add the checks at both places but if there's a sensible default it should be done once in the library rather than forcing all users to deal with nulls :D

My impression was that your? pull request to picoFeed already did that or am I wrong?

[schaal]

It wasn't my pull request, but looking at the code, it just sets publishedDate and updatedDate to whatever is in the feed, so if they're not in the feed, they are set to null.