Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Remove old FeedService and Mapper #990

Merged
merged 2 commits into from
Dec 30, 2020

Conversation

SMillerDev
Copy link
Contributor

This was a painful one, but I'm happy with the amount of code that got removed and restructured.

@SMillerDev SMillerDev force-pushed the chore/disable_v1_feed_service branch 5 times, most recently from 9cbb885 to cd2f43f Compare December 16, 2020 22:16
@SMillerDev SMillerDev added this to the 15.2.0 milestone Dec 16, 2020
lib/Hooks/UserDeleteHook.php Outdated Show resolved Hide resolved
lib/Service/FeedServiceV2.php Outdated Show resolved Hide resolved
lib/Service/ItemServiceV2.php Outdated Show resolved Hide resolved
tests/Unit/Controller/FeedControllerTest.php Outdated Show resolved Hide resolved
tests/Unit/Controller/FolderControllerTest.php Outdated Show resolved Hide resolved
tests/Unit/Controller/ItemControllerTest.php Outdated Show resolved Hide resolved
tests/Unit/Service/FeedServiceTest.php Outdated Show resolved Hide resolved
tests/Unit/Service/ItemServiceTest.php Outdated Show resolved Hide resolved
lib/Db/ItemMapper.php Show resolved Hide resolved
lib/Db/ItemMapper.php Outdated Show resolved Hide resolved
Copy link
Contributor

@anoymouserver anoymouserver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and first tests look good, great job!

@Grotax
Copy link
Member

Grotax commented Dec 30, 2020

I think we can merge this after a rebase and target the 15.2.0 release.
What do you guys think?

SMillerDev and others added 2 commits December 30, 2020 11:06
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
Co-authored-by: anoy. <anoymouserver@users.noreply.github.com>
@SMillerDev SMillerDev merged commit d3cd465 into nextcloud:master Dec 30, 2020
@SMillerDev SMillerDev deleted the chore/disable_v1_feed_service branch December 30, 2020 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants