Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not fetch user-status if user prop does not represent a user #1348

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Do not fetch user-status if user prop does not represent a user #1348

merged 1 commit into from
Aug 25, 2020

Conversation

georgehrke
Copy link
Contributor

fixes #1342

@georgehrke
Do not fetch user-status if user prop does not represent a user
67af9ac 
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke added 3. to review Waiting for reviews feature: avatar Related to the avatar component labels Aug 25, 2020
@georgehrke georgehrke mentioned this pull request Aug 25, 2020
Closed
@georgehrke georgehrke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 25, 2020
@georgehrke georgehrke merged commit 61ab3d2 into master Aug 25, 2020
@georgehrke georgehrke deleted the bugfix/1342/avatar_load_only_user branch August 25, 2020 17:49
@georgehrke georgehrke mentioned this pull request Aug 26, 2020
Closed
dartcafe
dartcafe reviewed Aug 28, 2020
View reviewed changes
Copy link
Contributor

@dartcafe dartcafe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im am not sure: shouldn't be isGuest checked aswell? In polls we use this for external users to prevent errors on generating the avatars.

@dartcafe
Copy link
Contributor

I withdraw the last comment. I changed using of the avatar.

@dartcafe dartcafe mentioned this pull request Sep 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dartcafe dartcafe dartcafe left review comments

@juliushaertl juliushaertl juliushaertl approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: avatar Related to the avatar component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Load online status only for users
4 participants
@georgehrke @dartcafe @juliushaertl @skjnldsv