Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove superfluous input close icon template #3859

Merged
merged 1 commit into from
Mar 4, 2023

Conversation

raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented Mar 4, 2023

The close/clear icon in the NcRawLinkInput component is not registered. However, since the default close button icon is already close, providing it is anyway superfluous. So this PR just removed the useless template. No visual or functional changes.

Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler changed the title Correctly show link input close icon Remove superfluous input close icon template Mar 4, 2023
@raimund-schluessler raimund-schluessler added 3. to review Waiting for reviews feature: richtext Related to the richtext component labels Mar 4, 2023
@raimund-schluessler raimund-schluessler added this to the 7.8.1 milestone Mar 4, 2023
@raimund-schluessler raimund-schluessler marked this pull request as ready for review March 4, 2023 21:31
@mejo- mejo- merged commit 7382e2c into master Mar 4, 2023
@mejo- mejo- deleted the fix/noid/link-input-close-icon branch March 4, 2023 22:39
@julien-nc julien-nc mentioned this pull request Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feature: richtext Related to the richtext component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants