-
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trusted proxy and trusted domain settings are lost #1334
Comments
ncc notify_push:setup https://REMOVED SENSITIVE VALUE/push 🗴 can't connect to push server: Server error: ncp-reportNextCloudPi diagnostics
Nextcloud configuration
HTTPd logs
Database logs
Nextcloud logs
|
so weird. There's more people seeing this https://help.nextcloud.com/t/configuring-hpb-with-ncp/123729/9 I'll try to reproduce but it didn't happen during my testing |
Sometimes only on the second restart. |
When I run nc-info I always have the notice that there are no certificates configured and they are. Running nc-info You should run Lets Encrypt for trusted encrypted access |
Might be related to #1333. The current notify_push configuration likely doesn't work for dynamic ips If my assumption is correct, it's not the reboot that's causing your issue but a change of your dynamic ip address (probably assigned by your ISP) |
Can you please connect to your instance over ssh, execute the following command and include its output (make sure to replace all IP addresses and urls with placeholders): ncc notify_push:self-test |
🗴 can't connect to push server: Server error: |
Perhaps the IP address. How can I reset the service to test that? |
That looks weird. Can you post the output of You can also try to rerun the notify_push setup with the following command: ncc notify_push:setup https://<your-nextcloud.domain>/push |
I don't have any output with ncc notify_push:log ncc notify_push:setup https://<your-nextcloud.domain>/push can't connect to push server: Server error: |
I was thinking about dynamic IP and I remembered something my.domain.tld is my Nextcloudpi LAN IP I don't think this is important but maybe can be |
That DNS setting and my router acting as proxy for everything can be the issue here. |
I think you can reset the HPB by rerunning Also, please check, if there's anything interesting in the output of |
I cleaned up the config.php and configured it correctly according to the configuration of another one in a test instance. The HPB service started to run correctly after a few seconds without requiring any intervention from me. Turned off the router's DHCP server and setup a DHCP/DNS server on the network to solve the problem with the router configured as a proxy. Forced a WAN IP update and rebooted the Nextcloupi. The new IP was automatically configured in config.php and the HPB service started normally. I think the problem is not caused by the dynamic IP. |
config.php trusted_domains trusted_proxies |
I noticed that the Client push app from Nextcloud app store was updated today right before this tests |
Did you manually add "my.domain.tld" to the trusted proxies? I don't think that will do anything (would require a reverse DNS lookup, which you most likely have not setup and I would surprised if NC would support that, in other words: Nextcloud doesn't know whether a request comes from the IP associated with that domain or not). Do you know what you changed in the config.php? Overwriting the trusted domains might cause other issues down the road because nextcloudpi assumes various "slots" in that array to mean specific things (see here). |
No, the domain was added to the trusted proxies by the Nextcloud in the test instance installation. Only added nextcloudpi to the trusted domains due to a error shown in the installation also in the test instance. Was added with the Nextcloudpi control panel. I talked about the Client push app because the update has a warning that says it is necessary to reconfigure with "notify_push:setup" after the update. When I installed the test instance (Debian 10 x86_64, curl installation), the client push app installed was the updated version. Maybe the issue was adjusted there. What I changed in config.php was: |
Tested v1.39.2 RPI4 4GB last rpi image The HBP service was down Trusted domains trusted proxies I'm sure that issue is due to my router but I can not test in another one. Created symlink /etc/systemd/system/multi-user.target.wants/notify_push.service → /etc/systemd/system/notify_push.service. If you're having issues getting the trusted proxy setup working, you can try bypassing any existing reverse proxy |
The previous test was a clean installation With Debian 10 x86_64 and curl installation. |
503 sounds like the notify_push service is not running (we should check with I pushed something today that I think might fix it. This would be related to #1332 |
Unless we are still seeing the 503, let's close this and follow up on the redis junk error on #1332 |
this issue is now giving me error "Your "trusted_proxies" setting is not correctly set, it should be an array of IP addresses - optionally with range in CIDR notation" in the latest Nextcloudpi |
@thor9898 Are you on Nextcloud 25.0.8? That's not officially supported yet and I'm just now resolving this issue |
I am on 28.0.5 |
@thor9898 Please update to NCP v1.54.0 (run |
Thanks, it worked!!! |
I am having the same issue where on reboot, my public hostname (duckdns) and wan ip is added to the array of proxies in config.php. NextcloudPi version | v1.54.2 This means i get the warning that thor9898 had in the overview. I can manually remove the hostname from the array and restart php fpm using systemd and the config is loaded without the hostname, but as soon as i reboot the machine the hostname is added again. |
Trusted proxy and trusted domain settings are lost if you reboot the Nextcloud.
Debian 10 x86_64, curl installation
After the reboot all the configuration always need to be set again in order to have the HPB service running again
The text was updated successfully, but these errors were encountered: