Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rm path for update package #1625

Open
wants to merge 5 commits into
base: devel
Choose a base branch
from
Open

Commits on Oct 2, 2022

  1. Change backup directory for docker compatibility

    Improve docker compatibility: Change the backup directory for ./nextcloud/data to reside within the host file system (basedir) so as to avoid moving the data folder back and forth between the docker container and the host file system. In situations where the nextcloud data takes up more than the free available space on the host system, this may lead to loosing some or all of the data.
    
    Signed-off-by: MB-Finski <64466176+MB-Finski@users.noreply.github.com>
    MB-Finski committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    880c6ff View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2022

  1. Configuration menu
    Copy the full SHA
    0472960 View commit details
    Browse the repository at this point in the history
  2. Temporarily place backup to BASEDIR

    Improves docker compatibility. Placing the backup file in /var/www/ will cause a failure in rolling back the update on containerized setups ("Can only restore from ext/btrfs/zfs filesystems"). The host filesystem is most likely compatible so using $BASEDIR as the backup location *should* solve this issue for most users.
    
    Signed-off-by: MB-Finski <64466176+MB-Finski@users.noreply.github.com>
    MB-Finski authored and theCalcaholic committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    10a7c01 View commit details
    Browse the repository at this point in the history
  3. Merge pull request nextcloud#1613 from MB-Finski/patch-1

    Change backup directory for docker compatibility
    theCalcaholic committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    c04ff3a View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2022

  1. Fix rm path for update package

    Fixes a bening bug where the nextcloud update package won't be removed after unpacking when the code is run inside a docker container.
    
    Also, for readability/clarity, remove an unnecessary "/var/www" from a cp command. 
    
    Signed-off-by: MB-Finski <64466176+MB-Finski@users.noreply.github.com>
    MB-Finski committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    288f0a9 View commit details
    Browse the repository at this point in the history