Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rx markdown, Undo for "Swipe to delete", Nextcloud rebrand #164

Merged
merged 10 commits into from Jan 19, 2017
Merged

Rx markdown, Undo for "Swipe to delete", Nextcloud rebrand #164

merged 10 commits into from Jan 19, 2017

Conversation

stefan-niedermann
Copy link
Member

#2 Render markdown inline
#147 Move from ownCloud to Nextcloud
#144 Undo for "Swipe to delete"

@stefan-niedermann stefan-niedermann changed the title Rx markdown Rx markdown, Undo for "Swipe to delete", Nextcloud rebrand Jan 19, 2017
@stefan-niedermann stefan-niedermann merged commit 958759f into master Jan 19, 2017
@stefan-niedermann stefan-niedermann deleted the RxMarkdown branch January 19, 2017 10:02
@korelstar
Copy link
Member

Please note, that a release critical bug is still open: yydcdut/RxMarkdown#19.

@korelstar
Copy link
Member

@stefan-niedermann
Please be careful when using the Squash and merge functionality on a branch with commits from different authors. It seems that only the first author is retained. Due to this, the git log now shows you as the author of the changes I did in this branch. That's not so cool. Next time, please squash commits (of one author) manually (if necessary) and then perform a merge commit.

@stefan-niedermann
Copy link
Member Author

I'm sorry, i wasn't aware of this. Maybe i have later some time to fix the git history - should be possible.
Be sure you will be prominently mentioned in all release notes :) (as soon as the critical rxmd bug has been fixed).
BTW i can not reproduce your issue with current master on my Nexus 5X. Create new note, type "Test", remove everything. Everything seems to be fine, am i missing something?
You are welcome to contact me directly via email or just have a call. my contact details are at my website.

@korelstar
Copy link
Member

No need to be mentioned prominently, it was just about the logs, because that could be important sometime (although it's likely that it's not). 😉

I've sent you an e-mail ...

@korelstar korelstar added this to the 0.10.0 milestone Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stefan-niedermann @korelstar