Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline commons version #1771

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Streamline commons version #1771

merged 1 commit into from
Apr 17, 2023

Conversation

tobiasKaminsky
Copy link
Member

closes #1769
closes #1768
closes #1767
closes #1763

stefan-niedermann
stefan-niedermann reviewed Apr 17, 2023
View reviewed changes
Copy link
Member

@stefan-niedermann stefan-niedermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can be merged.

Hint: Missing the QS version of the files app. The behavior is identical to before this PR, just a note, that in the future it might make sense to iterate the enum entries (or better check which account type is actually used)

@tobiasKaminsky @AndyScherzinger
Streamline commons version
d22093f 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@AndyScherzinger AndyScherzinger added this to the 4.1.0 milestone Apr 17, 2023
@stefan-niedermann stefan-niedermann mentioned this pull request Apr 17, 2023
Closed
@AndyScherzinger AndyScherzinger merged commit a7f921b into main Apr 17, 2023
10 of 11 checks passed
@AndyScherzinger AndyScherzinger deleted the bumpCommons branch April 17, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefan-niedermann stefan-niedermann stefan-niedermann left review comments

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tobiasKaminsky @AndyScherzinger @stefan-niedermann