#422 Rxmarkdown update #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
v0.1.3 has been released https://github.com/yydcdut/RxMarkdown/releases/tag/v0.1.3 yydcdut/RxMarkdown#50 should be fixed in this release. As soon as i have some time i will update and see how to fix the checkbox-issues. |
Remove support of toggling checkboxes due to bugs
|
Sorry to disappoint you, but i removed the support for toggling checkboxes for now because it still causes errors. I will open a new issue to track it since it basically is possible now. But to move on, we should first upgrade without adding more features. |
Removes the auto-linking feature since it has been implemented upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #422, #287 and #157
This is a basic implementation of v0.1.2 of RxMarkdown using the Reactive X way.
It also implements toggling checkboxes from within the view mode.
problems left:
After toggling a checkbox the content is displayed as plain text and does not get processed anymore (unti switching to edit mode and back to view mode)toggling the last checkbox (last line) causes the last letter of this line to disappear. Not sure yet if this is a bug of RxMarkdown or a result of wrong usage.Checkbox support is out of scope because it still causes errors.
I did not have any success implementing this without Reactive X (the checkbox-listener was not called - maybe a bug, too).