Put star on the left side of the note

[jancborchardt]

Currently it’s on the right side. We should put it on the left side to be consistent with the sidebars in other apps.

For that, the <ul> just needs the class="with-icon" to have padding to the left. Then the star can be positioned on the left of it.

cc @korelstar @Henni

[jancborchardt]

(Then it’s also not that close to the delete button anymore which is a bit safer. ;)

[korelstar]

@jancborchardt Hmmm. Typically, the icon left to the text in the navigation sidebar is a visual representation of the text/entry and hence represents the navigation entry without providing a new action. This applies to calendar, files and tasks (I'm not aware of another usage!).

For notes, the icon has it's own action which is not choosing the navigation entry like in the other apps. So it's a complete other use of the icon. If both the icon are at the same position in both use cases, this could be confusing.

[jancborchardt]

@korelstar good points. However even for Calendar, the navigation is very different. There, clicking the navigation entry as well as circle toggles visibility instead of switching to a different group.

And in Notes the navigation is a file list. For Files, the file list has the star function on the left of the file. That’s also where it would belong for Notes, even though the list is in the sidebar. :) It’s definitely strange next to the delete button, having the action of »I like this note a lot« and »I hate this note and it’s useless« so close to each other. ;)

[iSpeeX]

"For notes, the icon has it's own action"
I didn't understand your answer about that left-icon in Notes. In my Notes app (web), i have no icons on any note, is it normal ?

[korelstar]

Maybe, you just haven't any notes marked as favorite. If you mouseover a note in the navigation bar, you see a gray star (currently on the right from the note's title). If you click on that star, the note will be marked as favorite.

However, in version 3.0 of the notes app, this behavior will change (see #290 and the discussion under nextcloud-libraries/nextcloud-vue#246) and we will have the star icon on the left side as requested by @jancborchardt

[iSpeeX]

Well I have some favorites but still no icons on the left of notes titles. I think i may have misunderstand the whole point.

Thank you for you answer, you guys seems to be very comitted to this project, it's really nice

[korelstar]

In the current version, 2.5.1, the star isn't on the left side. It's on the right side. From Version 3.0, the star will move to the left side, but toggling the favorite has to be done using a new submenu (three-dot-menu). In all versions, the star indicates if the note is a favorite (yellow) or not (gray). The gray star is only shown, if the note is active or hovered.

[korelstar]

This is how it looks in #290:

[jancborchardt]

@korelstar very very cool! One tiny thing: If the note is favorited, in the menu it should say "Unfavorite" to reflect what it will do.

[korelstar]

@jancborchardt I've fixed the labels, I'm using the exact wording (and icons) from the files app, now: a78221f