Settings: Move Settings to NcAppSettingsDialog, NotePath FilePicker and merge AppHelp #1003
Conversation
|
I think it makes sense to combine this directly with #990. We could even follow the Talk app and merge the help sections about keyboard shortcuts also into the same dialog:
|
|
I'll merge these two PRs. Looking at #967 I would keep everything from the help menu except the markdown hints because they are already in the richtext editor, wouldn't I ? |
theatischbein
force-pushed
the
settings-dialog
branch
from
23dbfc9
to
a99432a
Compare
theatischbein
force-pushed
the
settings-dialog
branch
2 times, most recently
from
ea80bce
to
a1cc1f2
Compare
|
Fortunately there is no need anymore for my workaround when clicking inside the filePicke :) I wasn't sure how you handle commits in this project. I did a seperate commit for every step, but I would also squash them if that fits your guideline! Current state:
|
theatischbein
changed the title
|
@juliushaertl Any update on this ? |
theatischbein
changed the title
|
Looks great from the screenshots. I'll review it later today. Sorry for the delay. |
|
Regarding the commits, individual ones are fine if they are cleanly separated as yours are 👍 |
NcAppNavigationSettings Signed-off-by: Jonathan Pagel <jonny_tischbein@systemli.org>
Signed-off-by: Jonathan Pagel <jonny_tischbein@systemli.org>
theatischbein
force-pushed
the
settings-dialog
branch
from
a1cc1f2
to
0403f45
Compare
| <AppSettings v-if="!loading.notes && error !== true" @reload="reloadNotes" /> | ||
| <ul class="app-navigation-entry__settings"> | ||
| <NcAppNavigationItem | ||
| :title="t('notes', 'Notes settings')" |
There was a problem hiding this comment.
Not blocking as we can follow up.
@nimishavijay What would be your take on the wording here? Should we maybe call this "Notes settings / help" since the content is a bit more than just settings? See screenshots from before for a full overview.
There was a problem hiding this comment.
Hm, that's a good point. Looking at other apps, Talk and Calendar have keyboard shortcuts as part of their settings. So I think it is expected to have shortcuts there :) As a follow up, there could be the functionality of pressing the key ? to bring up the keyboard shortcuts section of the settings, but that is totally a future enhancement. For now I'd say the wording is fine as it is :)
juliushaertl
added
enhancement
|
@jonnytischbein Could you fix the remaining lint errors? |
Signed-off-by: Jonathan Pagel <jonny_tischbein@systemli.org>
theatischbein
force-pushed
the
settings-dialog
branch
from
0403f45
to
8982461
Compare
|
Thank you so much! :) I missed to run lint at the end again. Fixed it now |
Closes #969
Like discussed in #990 I just the Settings Dialog instead of the Navigation Settings.
For the settings button I had to use a css workaround from the files app.
Personally I would like to merge this PR with the file picker from #990 as reference I can recommend to look at the photos app.