Fix dashboard icons #1124
Merged
Fix dashboard icons #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jld3103 <jld3103yt@gmail.com>
provokateurin
force-pushed
the
fix/dashboard-icons
branch
from
9e10b62
to
c807dd8
Compare
blizzz
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
getAbsoluteURLtwice leads to URLs likehttp://localhost/http://localhost/apps/notes/img/notes-dark.svg.I think this never got noticed because the web frontend doesn't directly use the items but the custom Javascript rendering instead. Maybe that is broken as well since no icon is displayed there?