Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent favorite tooltip from occurring twice. #251

Merged
merged 1 commit into from Sep 1, 2018
Merged

Prevent favorite tooltip from occurring twice. #251

merged 1 commit into from Sep 1, 2018

Conversation

muety
Copy link
Contributor

@muety muety commented Sep 1, 2018

Attempt to fix #118. Could only reproduce that problem in Firefox, not in Chrome.

Additionally resolves the issue that after having unstarred a note, the user does not receive feedback about whether the action was successful. This is due to the fact that the star keeps its focus until the user clicks on any other element and therefore still stays yellow, although the note is note starred anymore.

@korelstar korelstar merged commit 55a8702 into nextcloud:master Sep 1, 2018
@korelstar
Copy link
Member

Nice! 🎉

Thank you very much for this fix!

@korelstar korelstar added this to the 2.4.2 milestone Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

»Favorite« tooltip stays open when clicked
2 participants