Code refactoring; improved favorite setting #409

korelstar · 2019-11-17T09:15:18Z

inject TagManager in NotesService
refactor: extract common code into method in Db\Note
update favorite only if different to current state (refers to Notes app causes server exceptions (due orphaned favorites?) #407)

korelstar added 2 commits November 16, 2019 23:35

inject TagManager

8bc24b8

refactor: extract common code into method

18befdd

korelstar added this to the 3.1.0 milestone Nov 17, 2019

update favorite only if different to current state

3909d6d

korelstar force-pushed the code branch from 8c832c3 to 3909d6d Compare November 17, 2019 09:18

korelstar added 2 commits November 17, 2019 22:00

fix getTagsForObjects can be boolean

e91ebff

fix unreachable code

59c29f7

korelstar marked this pull request as ready for review November 19, 2019 12:21

korelstar merged commit 21c33e1 into master Nov 19, 2019

delete-merged-branch bot deleted the code branch November 19, 2019 12:21

korelstar mentioned this pull request Nov 27, 2019

Notes app causes server exceptions (due orphaned favorites?) #407

Closed

Provide feedback