Minor changes #42
Minor changes #42
Conversation
This is much cleaner and clearer to the user.
just a simple find and replace, mostly for clarity and to fix some links.
| * Report the issue using our [template][template], it includes all the information we need to track down the issue. | ||
|
|
||
| Help us to maximize the effort we can spend fixing issues and adding new features, by not reporting duplicate issues. | ||
|
|
||
| [template]: https://raw.github.com/owncloud/core/master/issue_template.md | ||
| [template]: https://raw.github.com/nextcloud/core/master/issue_template.md |
|
|
||
| ### Contribute Code and translations | ||
| Please check [core's contribution guidelines](https://github.com/owncloud/core/blob/master/CONTRIBUTING.md) for further information about contributing code and translations. | ||
| Please check [core's contribution guidelines](https://github.com/nextcloud/core/blob/master/CONTRIBUTING.md) for further information about contributing code and translations. |
|
@PhSc you're right, I updated it to be uppercased in the header comments. |
| @@ -9,7 +9,6 @@ | |||
| } | |||
|
|
|||
| #app-navigation #note-add span { | |||
| display: none; | |||
There was a problem hiding this comment.
@jancborchardt what do you think about this?
We get the demand to show the text every once in a while.
There was a problem hiding this comment.
I vote for displaying the text always. And I vote for displaying it more like a button, like in the contacts app (cp. #14 (comment)):
There was a problem hiding this comment.
Personally I think it adds clarity, and overall looks better. Having it look like a button like @korelstar said would also be nice, though was somewhat out of scope of what i was going for in this PR.
| * This repository ([notes](https://github.com/owncloud/notes/issues)) is *only* for issues within the ownCloud notes code. | ||
| * __SECURITY__: Report any potential security bug to security@owncloud.com following our [security policy](https://owncloud.org/security/) instead of filing an issue in our bug tracker | ||
| * This repository ([notes](https://github.com/nextcloud/notes/issues)) is *only* for issues within the nextcloud notes code. | ||
| * __SECURITY__: Report any potential security bug to security@nextcloud.com following our [security policy](https://nextcloud.com/security/) instead of filing an issue in our bug tracker |
There was a problem hiding this comment.
I'm not sure this advice is still valid or if that mail address even exists.
@LukasReschke any advice?
There was a problem hiding this comment.
I was also unsure if that email existed, so decided to change it anyway. If anyone knows better please just tell me.
| @@ -1,6 +1,6 @@ | |||
| ## Submitting issues | |||
|
|
|||
| If you have questions about how to install or use ownCloud, please direct these to the [mailing list][mailinglist] or our [forum][forum]. We are also available on [IRC][irc]. | |||
| If you have questions about how to install or use nextcloud, please direct these to the [mailing list][mailinglist] or our [forum][forum]. We are also available on [IRC][irc]. | |||
There was a problem hiding this comment.
It's nit-picking, but could you please uppercase Nextcloud?
| @@ -11,19 +11,19 @@ If you have questions about how to install or use ownCloud, please direct these | |||
| - Go to one of the repositories, click "issues" and type any word in the top search/command bar. | |||
| - You can also filter by appending e. g. "state:open" to the search string. | |||
| - More info on [search syntax within github](https://help.github.com/articles/searching-issues) | |||
| * This repository ([notes](https://github.com/owncloud/notes/issues)) is *only* for issues within the ownCloud notes code. | |||
| * __SECURITY__: Report any potential security bug to security@owncloud.com following our [security policy](https://owncloud.org/security/) instead of filing an issue in our bug tracker | |||
| * This repository ([notes](https://github.com/nextcloud/notes/issues)) is *only* for issues within the nextcloud notes code. | |||
|
@Henni I made the requested changes. Anything else you would like me to do? |
|
From my side it's ok. But @Henni has to decide. |
|
Good stuff @rushsteve1! :) Added you to the Nextcloud organization by the way – welcome! |
A couple of quick (and admittedly a bit dirty) changes to make things a bit clearer for the user and the developers:
Changed any instance of 'ownCloud' to 'nextcloud'. This updated a lot of links to the proper locations, and generally made it clearer that this is Nextcloud notes.
This one is more my opinion, but the 'New Note' text should be visible while not hovered over. The pop-in was ugly and jarring and it is much clearer to the user the function of that link.
Any further alterations you would like me to make please just ask.