Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improved error handling #449

Merged
merged 5 commits into from
Feb 1, 2020
Merged

improved error handling #449

merged 5 commits into from
Feb 1, 2020

Conversation

korelstar
Copy link
Member

  • roll back note creation on error (prevents repeated creation of empty notes when an error occurs while creating a new note using 3rd-party-API)
  • use DataResponse instead of legacy respond()
  • send HTTP 507 if storage is insufficient (fixes Return HTTP Status 507 when storage is full #438)

@korelstar korelstar added this to the 3.1.2 milestone Feb 1, 2020
@korelstar korelstar merged commit 10d0d6f into master Feb 1, 2020
@delete-merged-branch delete-merged-branch bot deleted the error-handling branch February 1, 2020 16:47
@korelstar korelstar added the feature: API Related to the API for 3rd-party apps, i.e. Android or iOS label Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature: API Related to the API for 3rd-party apps, i.e. Android or iOS
Projects
None yet
Milestone
3.1.2
Development

Successfully merging this pull request may close these issues.

Return HTTP Status 507 when storage is full
1 participant
@korelstar