Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty list of notifications to delete #1253

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Handle empty list of notifications to delete #1253

merged 1 commit into from
Aug 16, 2022

Conversation

CarlSchwan
Copy link
Member

Save two query

Signed-off-by: Carl Schwan carl@carlschwan.eu

@CarlSchwan
Handle empty list of notifications to delete
151209f 
Save two query

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan CarlSchwan added this to the Nextcloud 25 milestone Aug 16, 2022
@CarlSchwan CarlSchwan self-assigned this Aug 16, 2022
@github-actions
Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 9470 was 9300 (+1.82%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@nickvergessen nickvergessen merged commit 563c9c8 into master Aug 16, 2022
@nickvergessen nickvergessen deleted the handle-empty-list-of-notifications-to-delete branch August 16, 2022 11:40
@skjnldsv skjnldsv mentioned this pull request Aug 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees

@CarlSchwan CarlSchwan

Labels
3. to review
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CarlSchwan @nickvergessen