Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn about undelivered notifications #1265

Merged
merged 3 commits into from Aug 31, 2022
Merged

Warn about undelivered notifications #1265

merged 3 commits into from Aug 31, 2022

Conversation

nickvergessen
Copy link
Member

No description provided.

@nickvergessen
Show a warning about undelivered notifications
16a1590 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Recompile
0863126 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 25 milestone Aug 31, 2022
@github-actions
Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 9470 was 9300 (+1.82%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

PVince81
PVince81 reviewed Aug 31, 2022
View reviewed changes
src/NotificationsApp.vue
@@ -32,6 +33,15 @@
<transition-group class="notification-wrapper"
name="list"
tag="ul">
<Notification v-if="hasThrottledPushNotifications"
:key="-2016"
datetime="warning"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

datetime=warning ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, its a hack to identify this notification inside the component...

PVince81
PVince81 approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 code looks fine

@nickvergessen
Fix max-attributes-per-line
8cb0e9b 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@github-actions
Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 9471 was 9300 (+1.83%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@nickvergessen nickvergessen merged commit f1e5830 into master Aug 31, 2022
@nickvergessen nickvergessen deleted the feature/noid/warn-about-undelivered-notifications branch August 31, 2022 12:09
@blizzz blizzz mentioned this pull request Sep 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

Assignees
No one assigned
Labels
4. to release enhancement feature: frontend 🖌️ feature: push 📲
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nickvergessen @PVince81