Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to contacts #150

Open
stefan-niedermann opened this issue Jan 3, 2017 · 6 comments
Open

Add to contacts #150

stefan-niedermann opened this issue Jan 3, 2017 · 6 comments

Comments

@stefan-niedermann
Copy link
Member

Given you are viewing a conversation in ocsms
When the contact does not exists in the contacts app
Then there should be an action to quickly add this contact to the contacts app

add

Open questions

  • What exactly happens when a user triggers this action?
    • User is redirected to contacts app?
      • Pros: User can directly start editing the new contact
      • Cons: User is thrown out of the "ocsms flow"
    • Contact is silently created in the background?
      • Pros: User is can read on messages in ocsms
      • Cons: The created contact has no name - it is only a phone number without any accosiation

Your thoughts @nerzhul ?

@nerzhul
Copy link
Collaborator

nerzhul commented Jan 3, 2017

Hmmm it's not very simple, i think redirecting to contact app could be good, but i don't know if contact app is made to show the form with some form fields written.

@stefan-niedermann
Copy link
Member Author

stefan-niedermann commented Jan 3, 2017

Maybe @skjnldsv can give us some input about how an integration could look like?

@skjnldsv
Copy link
Member

skjnldsv commented Jan 3, 2017

Right now you can't since we don't allow some url mechanism to create contacts.
You could create a link to the contact if it exist though.
But it could be a great idea!

@stefan-niedermann
Copy link
Member Author

You could create a link to the contact if it exist though.

That's the problem because it does not exist in this case :) We'd like to create one.
A URL-mechanism seems to be a good idea. Maybe one can create an issue in the contacts app repo and link it?

@nerzhul
Copy link
Collaborator

nerzhul commented Jan 3, 2017

it could be interesting to have an API call to ContactManager service which provides the URL

@Diablofan
Copy link
Contributor

My problem, and I think this is similar enough, is that I have all of the contacts added to my contacts but the SMS app doesn't pick up on the contacts and associate them with the conversation.

I think presenting a selector to select contacts (pulled from the contacts app) would be a good idea, leave creating contacts to the contacts app. Having a Create New Contact item that asks for just a name would be alright good enough in my opinion. Creating more detailed contacts should be done in the contacts app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants