Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid throwing during app setup when federation classes could not be queried #488

Merged
merged 1 commit into from Oct 23, 2023

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Oct 23, 2023

There could be cases where the app is loaded even though the server is unavailable (e.g. through a failing ldap connection) In this case querying FederationService will fail and the app has been disabled.

…t be queried

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl added 3. to review Waiting for reviews bug Something isn't working labels Oct 23, 2023
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me. I didn't test it though.

@juliushaertl juliushaertl merged commit 88ca15f into main Oct 23, 2023
19 checks passed
@juliushaertl juliushaertl deleted the bugfix/noid/catch-csp branch October 23, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants