-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache passwords locally #104
Comments
I won't cache passwords locally, this because it will cause a security thread. |
We are planning a revamp of server side encryption which should speed up your vault load times! ;) |
Also, down voting won't reopen the issue, if you want this you can implement it and send a PR. |
What? I think "offline support is not planned for the extension"? This would mean you do not accept PRs on this. If you accept PRs I would suggest to leave this issue open and tag it with "help wanted" (or a new tag, if you want). |
Caching, is a bad idea, this wil create a unnecessary risk(if its local it can be hacked/bruteforced), but i understand your frustration In order for a solution
|
GSM, EDGE? When using tethering with your phone or a laptop with SIM slot.
2-3. The first time this surprised me heavily, as I thought something did not work. (Usually you unlock your vault and want to login right away, maybe only refresh the current site…) |
the actual size is not a problem, most of the time, the issue with loading times is with the server side encryption, that is makin a heavy encryption task on the server side, so we plan to revamp that part a bit for it to load way faster and the exact same safe! |
Also adding client side cache won't fix any issue with loading times cause you still need to refresh the full vault from time to time to know if something changed. If somebody made a pull request it would be reviewed and might be accepted, but keeping an issue that we don't ever plan to add support with makes absolutely no sense. |
Right, but users would not notice it is loading in most cases. Likely the first site they login after logging in does not have a new password or so, and they can just login. Also the sync could be faster as it only needs to sync the changed passwords/delta…
It is a sign for potential contributors that this issue is "open to grab". |
@rugk if there are much more people that want this feature, we can take a look but for now we have other priorities. Thanks for the reporting this issue. |
rugk, we don't have any way to detect changed passwords, that's why i don't see any benefits from caching |
Okay, another idea would be to at least display a loading icon somewhere (in the icon instead of the red lock?) to show that the vault is being encrypted… |
We can only show text in that place, maybe a red passman icon does the job to show that the vault is being loaded? |
The red Passman icon already shows that the vault is locked. Maybe a yellow one making it a traffic light? 🚦 |
How about the |
Yeah, also possible. |
Side note: the reason I came looking for an offline cache isn't because of loading speeds, but because I self-host my Nextcloud and it's not accessible over the web (I don't have control over my home network). Since the extension doesn't keep a copy of the database, it does nothing at all when I'm not at home. And at home, instead of my laptop, I just use the PC that's running the Nextcloud instance, which makes this problem moot. I guess the workaround is to just use a normal standalone password manager instead. |
Steps to reproduce
Expected behaviour
You should instantly have your passwords available and so on…
Actual behaviour
Passman seems to have to fetch the passwords first from the server.
This is bad in two cases:
That's why you should cache the credentials offline, in an encrypted format, of course.
Configuration
Operating system: Linux
Browser: Firefox 54.0
Extension version: 1.4.1
Nextcloud version: 12
The text was updated successfully, but these errors were encountered: