Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to scroll down under add collaborators #1271

Closed
AndyXheli opened this issue Sep 20, 2022 · 7 comments
Closed

Unable to scroll down under add collaborators #1271

AndyXheli opened this issue Sep 20, 2022 · 7 comments
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working

Comments

@AndyXheli
Copy link
Contributor

To Reproduce
Steps to reproduce the behavior:

  1. Go to Photos
  2. Click on Albums
  3. Select the Share Icon on the right top
  4. Click on Search people or group
    image
@AndyXheli AndyXheli added 0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working labels Sep 20, 2022
@AndyXheli
Copy link
Contributor Author

Still an issue on NC 25 RC2

@artonge
Copy link
Collaborator

artonge commented Oct 3, 2022

Thanks for reporting @AndyXheli,

May I ask you to try to add the CSS properties height: 500px and overflow: scroll to the pop-up content and reports if it is fixing your issue?
If so, could you make a PR ?

@AndyXheli
Copy link
Contributor Author

@artonge You're Welcome! Yes sir not a problem. Could you guied me the file i need to change and ill test and create a PR

@artonge
Copy link
Collaborator

artonge commented Oct 3, 2022

You would have to target this element: https://github.com/nextcloud/photos/blob/master/src/components/Albums/CollaboratorsSelectionForm.vue#L48
So adding the code here should work: https://github.com/nextcloud/photos/blob/master/src/components/Albums/CollaboratorsSelectionForm.vue#L352

@AndyXheli
Copy link
Contributor Author

Looks good. Please see below :)

image

AndyXheli pushed a commit to AndyXheli/photos that referenced this issue Oct 3, 2022
Update CollaboratorsSelectionForm.vue
a1a6b6f 
Fix for nextcloud#1271

Signed-off-by: Andy Xheli <axheli@axtsolutions.com>
@AndyXheli AndyXheli mentioned this issue Oct 3, 2022
Merged
backportbot-nextcloud bot pushed a commit that referenced this issue Oct 6, 2022
@backportbot-nextcloud
Update CollaboratorsSelectionForm.vue
fcefb0e 
Fix for #1271

Signed-off-by: Andy Xheli <axheli@axtsolutions.com>
@artonge
Copy link
Collaborator

artonge commented Oct 7, 2022

Thanks again for fixing it @AndyXheli !!!

@artonge artonge closed this as completed Oct 7, 2022
@AndyXheli
Copy link
Contributor Author

Thank you for your help !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@artonge @AndyXheli