Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No cropping photo design #143

Closed
grenzverkehr opened this issue Jan 21, 2020 · 23 comments · Fixed by #435
Closed

No cropping photo design #143

grenzverkehr opened this issue Jan 21, 2020 · 23 comments · Fixed by #435
Labels
1. to develop Accepted and waiting to be taken care of design Related to the design discussion Being discussed good first issue Good for newcomers

Comments

@grenzverkehr
Copy link

In "Photos" all photos are cropped square. This representation already exists in the grid view. But in "Photos" the photos (and videos) should be in the foreground. They should therefore be presented uncut. At least there should be an option in "Photos" to present photos and videos uncropped and to share this view via public link.

Here are a few nice examples:
https://www.flickr.com/photos/dmtoh/
https://www.photocase.de/p/491889
https://stock.adobe.com/contributor/204990950/weerasak

Photos and videos are also presented uncut in Google Photos.

@skjnldsv skjnldsv added 0. Needs triage Pending approval or rejection. This issue is pending approval. design Related to the design discussion Being discussed labels Jan 21, 2020
@skjnldsv
Copy link
Member

skjnldsv commented Jan 21, 2020

@linuxrrze
Copy link

The "old" "gallery" app also had a nice (over)view for images, even handling wide panorama pictures, while efficiently using the available space.
This allowed a really nice view for pictures of different formats.

The plain square image display of "photos" looks much less attractive (and is cutting of lots of information by cropping the images).

I'd like to see a view mode like the one of the "gallery" app in the future.

@skjnldsv
Copy link
Member

I'd like to see a view mode like the one of the "gallery" app in the future.

I can already tell you this will not happens.
The layout was not satisfying us :)
Especially the panorama part, it was super hard to find te image you were looking for if you had tons of different sizes 😖

@linuxrrze
Copy link

Sorry to hear that - from my personal point of view it'll be much harder to find a panorama picture with the cropped view that's implemented now.

I've been using nextcloud/gallery extensively for my photos and I do have different sizes: I never had trouble with the "gallery" kind of view (I really like it) - so I'd disagree on that one.

I can however understand from a developer's perspective, that it's easier to do the square/crop thing (and it may even be required to make integration into nextcloud possible).

I'm just giving my point of view as a user - no offence meant ;-)

For now:
Will it be possible to use "gallery" instead of the "photo" app?

@skjnldsv
Copy link
Member

I'm just giving my point of view as a user - no offence meant ;-)

Of course! :)
None taken 🤗

Will it be possible to use "gallery" instead of the "photo" app?

No, the gallery is now deprecated, it was causing more issues than any good stuff.

I can however understand from a developer's perspective, that it's easier to do the square/crop thing (and it may even be required to make integration into nextcloud possible).

It's not about easiness, it's about what others do and what the user expect nowadays. Please see #145 for extensive discussion about this.

@linuxrrze
Copy link

Thanks for the hint to the other discussion.

If I got it right, there are plans to improve the view further in coming releases, and the current state is limited because version 18 needed to be released on time.
And as the screenshots posted as reference in thread #145 look quite nice, I'm hopeful that the photos app will get there somewhen soon ;-)

@nemihome
Copy link

I would also prefer a non cropping option but I'm ok with square which meens there is some space whasted but you see the full pic. That the same like the people which streched the 4:3 pictures in tv to 16:9 because the tv has this size. Some like that some don't.

@grenzverkehr
Copy link
Author

grenzverkehr commented Jan 22, 2020

Tiled View (row)

Tiled View (column)

Square View (uncroped)

Square View (croped)

  • Android Gallery, iPhoto

Almost all applications that are designed to present photos do without cropping and show the photos tiled view.

@nemihome
Copy link

But what does this mean? Is it good because nearly everyone does it? :)

In Jalbum it is possible to set an option what you like depending on skin.

Looks like this (Tiles view):
image

@jancborchardt
Copy link
Member

It’s not about the mass of apps, but who has most users – and by extension what people are most used to. @grenzverkehr That is, Android Gallery and iPhoto use cropped design, so this is a big reason why we went for it as the default and first implementation. :)

Yes, going forward there will likely be an option for this in the future as specified in #145 (comment) – this was already referenced by @skjnldsv above so not sure what else needs to be discussed? :)

@grenzverkehr
Copy link
Author

Just one more thought: for the smartphone you may be right about the distribution but certainly not about laptops / desktops.

@FanchTheSystem
Copy link

FanchTheSystem commented Feb 7, 2020

+1 I would like my photo to not be cropped too ! It some kind of breaking my own work as a phographer...

File app already show cropped photo, and allow search and management of this kind of file.
Maybe you should think about :

  • Why people will use photo app instead of file app ?
  • What are the use case you want to answer in a so called "photo app" ?

For example my personal workflow is : I use nextcloud to send shared link to people who are concerned by photo I take, I want them to see all the photo as they are, so they can choose which one they want to download. I use directory with an explicit name as album name.

@skjnldsv
Copy link
Member

skjnldsv commented Feb 7, 2020

I would like to thanks everyone for their feedback! It really helps! 🤗

@civita
Copy link

civita commented Mar 16, 2020

I also want justified layout as the Gallery App has. It looks better (I mean, in sense of beauty) and saves some spaces. For me, I have both portrait and landscape photos. With the justified layout, I can tell the aspect ratio efficiently without click on each photo. Please add such an option for users to choose with layout shown in the Photo app.

@dennorske
Copy link

https://fox.cla.ws/ uses a nice concept of tiling, using all the available space. Of course, some pictures appear to be a bit cropped and it can be weird for very wide pictures.
Otherwise is can remind a bit about Google photos when you zoom in on your list view

@jancborchardt
Copy link
Member

@skjnldsv let’s have a settings switch to change the view: "Don’t crop previews", unchecked by default. It will then use the view macOS photos has.

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of good first issue Good for newcomers and removed 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Mar 21, 2020
@Georg-Git
Copy link

Georg-Git commented Jun 6, 2020

@jancborchardt at least for sharing pictures I prefer the nicer view of a non cropped preview as default.

When You will stay with cropped previews as default I would request a parameter to be accepted in shared links e.g.: ?preview=noncropped

@Georg-Git
Copy link

Georg-Git commented Jun 6, 2020

@jancborchardt "not sure what else needs to be discussed?"

Because You still do not have accepted our use cases and users demands:

@grenzverkehr:
"to present photos and videos uncropped and to share this view via public link"
5 Likes!

@linuxrrze: "I never had trouble with the "gallery" kind of view (I really like it)"
2 Likes!

@FanchTheSystem: "I would like my photo to not be cropped too ! It some kind of breaking my own work as a photographer..."
5 Likes!

@civita: "I also want justified layout as the Gallery App has."
1 Like!

I found only one user comment in favour of squared grid view - without any likes.
All the other users preferred a non cropped view - obviously as default view.

But what is Your last answer under all these user remarks:
Photo App will stay with cropped view as default.
After all You still thinking at least about a cropped view, but not as default.

So sending a public link to my photo album to new users will start now in the fileview as default - and when the new user will find the icon, he is perhaps able to switch to the squared view nobody wants.

But as far as I understood the comments of the users in this and also in other threads: we want to send a public link to a photo album and this should be presented with non cropped preview icons - as default - not as fileview as default and not as squared view as default.

@jancborchardt
Copy link
Member

@Georg-Git don't worry, we will look into it.

Regarding the collected statistics on the likes: Remember that people who are absolutely fine with the cropped view will not show up here since they have no issue with it. It's an issue tracker, so it's not a proper tool to take a vote.

@Georg-Git
Copy link

And again a hit in the face of every user taking time to file a issue and give You hints for optimization. Git issues does not really matter to @jancborchardt - Git users are only a annoying minority....

Frank @karlitschek in a interview about owncloud:
"Auch die Entwicklercommunity ist geschrumpft, da das Unternehmen damals schlechte Entscheidungen getroffen hat. Ich habe damals versucht, das zu korrigieren, was mir leider nicht gelungen ist."

Now Frank is not using the photo app of nextcloud - perhaps because he is preferring a noncropped view as default:

https://karlitschek.de/photos/#

@jancborchardt
Copy link
Member

Hi @Georg-Git :) As said, the main issue here is that we have to find the time to implement this. Whenever we get to it, whatever people choose will be remembered, and also shown for people you share with via link.

Thanks for your patience and feedback. ❤️

@Mikescops
Copy link
Member

FYI

image

@grenzverkehr
Copy link
Author

Thank you very much for the implementation of the new photo view. But unfortunately it does not yet meet my requirements as a photographer. See this new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of design Related to the design discussion Being discussed good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants