Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More beautiful photo view #496

Closed
grenzverkehr opened this issue Oct 17, 2020 · 7 comments
Closed

More beautiful photo view #496

grenzverkehr opened this issue Oct 17, 2020 · 7 comments
Labels
design Related to the design enhancement New feature or request wontfix This will not be worked on

Comments

@grenzverkehr
Copy link

Thank you very much for the implementation of the new photo view. Here the photos are presented uncut. And that is good and right. But unfortunately it does not yet meet my requirements as a photographer. This has two reasons: On the one hand, the photos are presented clearly too small. Secondly, the square grid view does not meet my aesthetic requirements. Most photo platforms solve this better: here the photos are presented much bigger and more beautiful. Just to name a few: CC Search, Flickr, Google Photos, Amazon Photos, Microsoft Photos, Adobe Stock, Getty Images, 123RF, Shutterstock, pixabay, Photocase

It would be nice if Nextcloud Photos would also have the possibility to present photos in a large format. Instead of 7 photos in a row as now, only 3 photos in landscape format – on a Full HD monitor.

Here two views for comparison: CC Search and the new Nextcloud Photos view.

cc_search

nextcloud_photos

@grenzverkehr grenzverkehr added 0. Needs triage Pending approval or rejection. This issue is pending approval. enhancement New feature or request labels Oct 17, 2020
@Mikescops
Copy link
Member

Sorry it doesn't met your "requirements", if you're a photographer as you say, you should use dedicated tools like the open source http://www.darktable.org/!

The community projects like Nextcloud are not here to met "your" requirements but various number of users.

Please consider better wording in the future, your current request may be offensive for the contributors.

@skjnldsv @jancborchardt FYI

@Mikescops Mikescops added design Related to the design low Low priority labels Oct 17, 2020
@grenzverkehr
Copy link
Author

Please excuse my choice of words. I didn't mean to offend anyone. I just wanted to make a suggestion for another (from my point of view better and more beautiful) photo view.

@jancborchardt
Copy link
Member

Some points here:

  • We already have 2 different views, do we really want to add a 3rd one? Remember, all these have to be maintained, and normal people don’t change the default anyway
  • The drawback of the view you show @grenzverkehr is that while landscape photos are shown larger, portrait photos are comparably smaller.
  • The non-cropped view isn’t particularly beautiful, which is also why we went with the cropped one by default

@skjnldsv
Copy link
Member

  • We already have 2 different views, do we really want to add a 3rd one? Remember, all these have to be maintained, and normal people don’t change the default anyway

Agree too, I think those two are enough for now.

@pdroalves
Copy link

I support this issue, since I agree that current views lack good taste. The project could attract attention of people interested on organizing their photo library if we have a more modern way of presenting photos than current soulless-cropped option.

By the way, I don't see the problem with their choice of words. Probably it's a translation confusion and I don't see a reason to be rude with they =)

@wein-geist
Copy link

Regarding the wording, I see how it can be taken as offense : )

But from a design point of view, I agree 100% percent with @grenzverkehr , probably not a surprise for one or the other, as I have promoted this kind of grid in my community post.
It was even already suggested in #146 in a comment by @janis91, and @jancborchardt , you seemed more open to the idea then and even encouraged @janis91 to continue?

Regarding portrait and landscape pictures, I may have an idea (and another example of this filled view): Pixieset does it as described by @grenzverkehr but in columns.
image

Can this filled grid view be coded in a way, that columns (as pixieset) and lines (cc search and others) are essentially identical? This would help with the effort of maintaining them.

So, my suggestion would be:

  • cropped view
  • filled lines
  • filled columns

with one toggle button for switching between them, and making it a permanent setting for each album. So the user can switch easily and set the most optimal view for each album.

@skjnldsv
Copy link
Member

Hey! So, I'll take a final statement here for clarification :)

On nextcloud 21 we implemented the non-cropped view per community request (same design as macOs photos 😉)
localhost_8080_index php_apps_photos_

Currently, there is no plan from us to implement a third view (fitted columns) as this is far from our priorities (photos users have higher priority requests so far). Nonetheless, if anyone wants to implement this view, we would be fine for it, but the work is really considerable. You need a 100% fully working virtual scroller that supports this layout as well as date separators (no features regressions allowed). So far I don't think there is an available library that does that.

I will therefore close this issue for now, as more discussions will not add anything and unless someone else (community) wants to seriously dive into it, which we'll be happy to assist, we will not spend time on implementing the fitted columns so far. Maybe one day, in which case we'll re-open, but not for now :)

Hope everyone will understand 😉 🤗
Take care,
John

@skjnldsv skjnldsv added wontfix This will not be worked on and removed 0. Needs triage Pending approval or rejection. This issue is pending approval. low Low priority labels Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Related to the design enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

6 participants