Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish albums - second round #1247

Merged
merged 9 commits into from Sep 20, 2022
Merged

Polish albums - second round #1247

merged 9 commits into from Sep 20, 2022

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Sep 16, 2022 •
edited

  • Force menu for shared album content actions
  • Correctly redirect on shared album deletion
  • Add header to SharedAlbums
  • Add EmptyContent in CollaboratorSelectionForm
  • Refactor shared albums tests
  • Support receiving two albums with the same names
  • Add tests
    • to remove collaborator
    • to delete shared album
    • to edit album's name

@artonge artonge added 1. to develop Accepted and waiting to be taken care of 2. developing Work in progress feature: albums Related to the albums section labels Sep 16, 2022
@artonge artonge added this to the Nextcloud 25 milestone Sep 16, 2022
@artonge artonge self-assigned this Sep 16, 2022
@artonge artonge removed the 1. to develop Accepted and waiting to be taken care of label Sep 16, 2022
@artonge artonge changed the title Polish albums Polish albums - secound roud Sep 16, 2022
@artonge artonge changed the title Polish albums - secound roud Polish albums - secound round Sep 16, 2022
@artonge artonge changed the title Polish albums - secound round Polish albums - second round Sep 16, 2022
@blizzz blizzz mentioned this pull request Sep 19, 2022
Merged
@artonge
Force menu for shared album content actions
bf5b9f4 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Correctly redirect on shared album deletion
7060b48 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Add header to SharedAlbums
bde9865 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Add EmptyContent in CollaboratorSelectionForm
93e0114 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Add tests to remove collaborator
d51b070 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Add test to delete shared album
fe93511 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Add tests to adit album's name
66813e6 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Refactor shared albums tests
90c90cd 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Support receiving two albums with the same names
cdf57cb 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge merged commit 49b937a into master Sep 20, 2022
@artonge artonge deleted the polish/albums branch September 20, 2022 09:41
This was referenced Sep 20, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees

@artonge artonge

Labels
2. developing Work in progress feature: albums Related to the albums section
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@artonge @skjnldsv