Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable23] Run npm audit fix #1497

Merged
merged 2 commits into from Nov 24, 2022
Merged

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Nov 24, 2022

Signed-off-by: Louis Chemineau louis@chmn.me

@artonge artonge added 3. to review Waiting for reviews dependencies Pull requests that update a dependency file labels Nov 24, 2022
@artonge artonge added this to the Nextcloud 23.0.12 milestone Nov 24, 2022
@artonge artonge self-assigned this Nov 24, 2022
@blizzz blizzz mentioned this pull request Nov 24, 2022
8 tasks
@blizzz
Copy link
Member

blizzz commented Nov 24, 2022

CI is unhappy

@artonge
Copy link
Collaborator Author

artonge commented Nov 24, 2022

/compile amend /

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/deps/stable23/npm_audit branch from 65cbddf to eac599d Compare November 24, 2022 10:59
@blizzz
Copy link
Member

blizzz commented Nov 24, 2022

we have a problem with composer here (platform php dependency), but unrelated to this PR.

Node is also failing though .

@szaimen
Copy link
Contributor

szaimen commented Nov 24, 2022

Likely need to downgrade node to v16:

node:internal/crypto/hash:71
  this[kHandle] = new _Hash(algorithm, xofLen);
                  ^

Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:71:19)
    at Object.createHash (node:crypto:133:10)
    at BulkUpdateDecorator.hashFactory (/home/runner/work/photos/photos/node_modules/webpack/lib/util/createHash.js:145:18)
    at BulkUpdateDecorator.update (/home/runner/work/photos/photos/node_modules/webpack/lib/util/createHash.js:46:50)
    at SourceMapSource.updateHash (/home/runner/work/photos/photos/node_modules/webpack/node_modules/webpack-sources/lib/SourceMapSource.js:233:8)
    at NormalModule._initBuildHash (/home/runner/work/photos/photos/node_modules/webpack/lib/NormalModule.js:870:17)
    at handleParseResult (/home/runner/work/photos/photos/node_modules/webpack/lib/NormalModule.js:936:10)
    at /home/runner/work/photos/photos/node_modules/webpack/lib/NormalModule.js:1028:4
    at processResult (/home/runner/work/photos/photos/node_modules/webpack/lib/NormalModule.js:745:11)
    at /home/runner/work/photos/photos/node_modules/webpack/lib/NormalModule.js:809:5
    at /home/runner/work/photos/photos/node_modules/loader-runner/lib/LoaderRunner.js:406:3
    at iterateNormalLoaders (/home/runner/work/photos/photos/node_modules/loader-runner/lib/LoaderRunner.js:232:10)
    at iterateNormalLoaders (/home/runner/work/photos/photos/node_modules/loader-runner/lib/LoaderRunner.js:239:10)
    at /home/runner/work/photos/photos/node_modules/loader-runner/lib/LoaderRunner.js:254:3
    at context.callback (/home/runner/work/photos/photos/node_modules/loader-runner/lib/LoaderRunner.js:124:13)
    at /home/runner/work/photos/photos/node_modules/babel-loader/lib/index.js:59:71 {
  opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],
  library: 'digital envelope routines',
  reason: 'unsupported',
  code: 'ERR_OSSL_EVP_UNSUPPORTED'
}

Node.js v18.12.1

@szaimen
Copy link
Contributor

szaimen commented Nov 24, 2022

Adjust

photos/package.json

Lines 60 to 61 in 94885d7

"node": ">=14.0.0",
"npm": ">=7.0.0"

To ^14.0.0 and ^7.0.0

@artonge
Copy link
Collaborator Author

artonge commented Nov 24, 2022

Adjust

photos/package.json

Lines 60 to 61 in 94885d7

"node": ">=14.0.0",
"npm": ">=7.0.0"

To ^14.0.0 and ^7.0.0

Ah, just pushed with ~16.0.0. Should work too no ?

@szaimen
Copy link
Contributor

szaimen commented Nov 24, 2022

Adjust

photos/package.json

Lines 60 to 61 in 94885d7

"node": ">=14.0.0",
"npm": ">=7.0.0"

To ^14.0.0 and ^7.0.0

Ah, just pushed with ~16.0.0. Should work too no ?

I guess so... But better ask John 😉

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/deps/stable23/npm_audit branch from 7fa883e to cd3e614 Compare November 24, 2022 15:25
@artonge
Copy link
Collaborator Author

artonge commented Nov 24, 2022

~ is for patch
^ for minor

So I switched to minor and pushed again :)

https://docs.npmjs.com/about-semantic-versioning

@szaimen
Copy link
Contributor

szaimen commented Nov 24, 2022

You still need to recompile IIRC...

@artonge artonge merged commit 0488d56 into stable23 Nov 24, 2022
@artonge artonge deleted the artonge/deps/stable23/npm_audit branch November 24, 2022 15:29
@artonge
Copy link
Collaborator Author

artonge commented Nov 24, 2022

Different node version do not output different build :)

@artonge
Copy link
Collaborator Author

artonge commented Nov 24, 2022

Damn that was fast

@szaimen
Copy link
Contributor

szaimen commented Nov 24, 2022

Damn that was fast

Indeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants