Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent progress bar overflow when uploading in album content #1862

Merged
merged 1 commit into from Jun 8, 2023

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Jun 8, 2023

Same as #1785, but for albums

@artonge artonge self-assigned this Jun 8, 2023
@artonge artonge added bug Something isn't working 3. to review Waiting for reviews javascript Javascript related ticket labels Jun 8, 2023
@artonge artonge requested review from skjnldsv, a team, Pytal and szaimen and removed request for a team June 8, 2023 09:34
@artonge artonge added this to the Nextcloud 28 milestone Jun 8, 2023
@artonge
Copy link
Collaborator Author

artonge commented Jun 8, 2023

/backport to stable27

@artonge
Copy link
Collaborator Author

artonge commented Jun 8, 2023

/backport to stable26

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Jun 8, 2023
@artonge
Copy link
Collaborator Author

artonge commented Jun 8, 2023

/backport to stable25

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/fix/upload_progress_bar_position_in_albums branch from 9c483c7 to 7405dd5 Compare June 8, 2023 09:35
@szaimen
Copy link
Contributor

szaimen commented Jun 8, 2023

@artonge can you please post a screenshot what this fixes? :)

@artonge
Copy link
Collaborator Author

artonge commented Jun 8, 2023

@artonge can you please post a screenshot what this fixes? :)

See linked PR

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@artonge artonge merged commit ffe9d42 into master Jun 8, 2023
23 checks passed
@artonge artonge deleted the artonge/fix/upload_progress_bar_position_in_albums branch June 8, 2023 11:16
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request Pending backport by the backport-bot bug Something isn't working javascript Javascript related ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants