Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset selection state in route change #1888

Merged
merged 1 commit into from Jun 15, 2023

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Jun 15, 2023

When switching from "All media" to other timeline views like "Photos", the selection state should not be conserved.

x Before route change After route change
Before Screenshot from 2023-06-15 13-57-06 Screenshot from 2023-06-15 13-57-18
After Screenshot from 2023-06-15 13-57-06 Screenshot from 2023-06-15 13-57-13

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge self-assigned this Jun 15, 2023
@artonge artonge added bug Something isn't working 3. to review Waiting for reviews javascript Javascript related ticket labels Jun 15, 2023
@artonge artonge added this to the Nextcloud 28 milestone Jun 15, 2023
@artonge
Copy link
Collaborator Author

artonge commented Jun 15, 2023

/backport to stable27

@artonge
Copy link
Collaborator Author

artonge commented Jun 15, 2023

/backport to stable26

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Jun 15, 2023
@artonge
Copy link
Collaborator Author

artonge commented Jun 15, 2023

/backport to stable25

@artonge artonge requested review from a team, susnux, Fenn-CS and Pytal and removed request for a team June 15, 2023 12:00
@artonge artonge merged commit 7580ae5 into master Jun 15, 2023
23 checks passed
@artonge artonge deleted the artonge/fix/reset_selection_state branch June 15, 2023 14:26
@backportbot-nextcloud

This comment was marked as resolved.

@backportbot-nextcloud

This comment was marked as resolved.

@backportbot-nextcloud

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request Pending backport by the backport-bot bug Something isn't working javascript Javascript related ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants