Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unselect all button #1895

Merged
merged 1 commit into from Jul 5, 2023
Merged

Add unselect all button #1895

merged 1 commit into from Jul 5, 2023

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Jun 19, 2023

Add "Unselect all" button.

I went the easy way, as dynamically displaying action from the three dot menu based on the available space would require some changes in @nc/vue

I also took the opportunity to prevent selection in Places and Public album views as no actions can be done from those.

View After
Timeline Screenshot from 2023-07-05 14-41-31
Albums Screenshot from 2023-07-05 14-41-41

@artonge artonge self-assigned this Jun 19, 2023
@artonge artonge added enhancement New feature or request javascript Javascript related ticket 2. developing Work in progress labels Jun 19, 2023
@artonge artonge added this to the Nextcloud 28 milestone Jun 19, 2023
@artonge artonge marked this pull request as draft June 19, 2023 08:06
@artonge artonge force-pushed the artonge/feat/add_unselect_all branch from 64987b2 to cb3a3ff Compare July 4, 2023 14:43
@artonge artonge changed the title Add unselect all Add unselect all button Jul 5, 2023
@artonge artonge requested a review from skjnldsv July 5, 2023 12:46
@artonge artonge marked this pull request as ready for review July 5, 2023 12:46
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 5, 2023
@artonge artonge force-pushed the artonge/feat/add_unselect_all branch from cb3a3ff to 53194d9 Compare July 5, 2023 12:46
@artonge
Copy link
Collaborator Author

artonge commented Jul 5, 2023

/backport to stable27

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Jul 5, 2023
@artonge
Copy link
Collaborator Author

artonge commented Jul 5, 2023

/backport to stable26

@artonge
Copy link
Collaborator Author

artonge commented Jul 5, 2023

/backport to stable25

@artonge artonge requested review from a team, susnux, Pytal and Fenn-CS and removed request for a team July 5, 2023 12:55
Copy link
Contributor

@Fenn-CS Fenn-CS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@artonge artonge merged commit 6dea250 into master Jul 5, 2023
23 checks passed
@artonge artonge deleted the artonge/feat/add_unselect_all branch July 5, 2023 20:12
@backportbot-nextcloud

This comment was marked as resolved.

@backportbot-nextcloud

This comment was marked as resolved.

@backportbot-nextcloud

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request Pending backport by the backport-bot enhancement New feature or request javascript Javascript related ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants