Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out some permission for public albums #2103

Merged
merged 1 commit into from Oct 25, 2023

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Oct 25, 2023

Remove some permissions for photos in public albums.

This prevent the viewer to display some unavailable actions, like delete and edit.

The G permissions was previously removed but no idea why. I replaced it with the R permissions as this one is useless in Photos.

Ref: https://docs.nextcloud.com/server/latest/developer_manual/client_apis/WebDAV/basic.html#webdav-basics

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge self-assigned this Oct 25, 2023
@artonge artonge requested a review from skjnldsv October 25, 2023 14:20
@artonge artonge added bug Something isn't working 3. to review Waiting for reviews php PHP related ticket labels Oct 25, 2023
@artonge
Copy link
Collaborator Author

artonge commented Oct 25, 2023

/backport to stable27

@artonge
Copy link
Collaborator Author

artonge commented Oct 25, 2023

/backport to stable26

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Oct 25, 2023
@artonge
Copy link
Collaborator Author

artonge commented Oct 25, 2023

/backport to stable25

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@artonge artonge merged commit 5dd5af6 into master Oct 25, 2023
28 checks passed
@artonge artonge deleted the artonge/fix/available_action_public_album_photos branch October 25, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request Pending backport by the backport-bot bug Something isn't working php PHP related ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants