Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EXIF display conditions #2135

Merged
merged 1 commit into from Nov 16, 2023
Merged

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Nov 16, 2023

Those are more specific and prevent errors.

@artonge artonge self-assigned this Nov 16, 2023
@artonge artonge requested review from a team, Fenn-CS, sorbaugh and emoral435 and removed request for a team November 16, 2023 14:45
@artonge artonge added bug Something isn't working 3. to review Waiting for reviews javascript Javascript related ticket labels Nov 16, 2023
@artonge artonge added this to the Nextcloud 28 milestone Nov 16, 2023
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/fix/exif_display_conditions branch from 5c36ecb to 2a898ca Compare November 16, 2023 14:49
@artonge artonge requested review from susnux and Pytal and removed request for sorbaugh November 16, 2023 17:08
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, the new conditions look good!

@artonge artonge merged commit c350bda into master Nov 16, 2023
23 checks passed
@artonge artonge deleted the artonge/fix/exif_display_conditions branch November 16, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working javascript Javascript related ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants