Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust favorite icon to be accessible #2190

Merged
merged 1 commit into from Dec 13, 2023
Merged

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Dec 12, 2023

Fix #2159

This basically copies the favorite icon from the files app (we should probably add it to @nextcloud/vue).

@susnux susnux added bug Something isn't working 3. to review Waiting for reviews accessibility labels Dec 12, 2023
@susnux susnux added this to the Nextcloud 29 milestone Dec 12, 2023
@susnux
Copy link
Contributor Author

susnux commented Dec 12, 2023

/backport to stable28

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Dec 12, 2023
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@artonge artonge merged commit dabd93e into master Dec 13, 2023
24 checks passed
@artonge artonge deleted the fix/a11y-favorite branch December 13, 2023 09:51
@susnux
Copy link
Contributor Author

susnux commented Dec 15, 2023

/backport to stable28

@backportbot-nextcloud
Copy link

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews accessibility backport-request Pending backport by the backport-bot bug Something isn't working feedback-requested
Projects
None yet
2 participants